From owner-svn-src-all@freebsd.org Fri Jan 11 21:04:45 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6D86149D753; Fri, 11 Jan 2019 21:04:45 +0000 (UTC) (envelope-from lars@e.0x20.net) Received: from mail.0x20.net (mail.0x20.net [46.251.251.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "0x20.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6980A87FF3; Fri, 11 Jan 2019 21:04:45 +0000 (UTC) (envelope-from lars@e.0x20.net) Received: from e.0x20.net (mail.0x20.net [46.251.251.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.0x20.net (Postfix) with ESMTPS id 7CD3A98917; Fri, 11 Jan 2019 22:03:56 +0100 (CET) Received: (from lars@localhost) by e.0x20.net (8.15.2/8.15.2/Submit) id x0BL3usZ057521; Fri, 11 Jan 2019 22:03:56 +0100 (CET) (envelope-from lars) Date: Fri, 11 Jan 2019 22:03:56 +0100 From: Lars Engels To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r342945 - in head: tools/build/mk usr.sbin/bluetooth usr.sbin/bluetooth/bluetooth-config Message-ID: <20190111210356.GA1267@e.0x20.net> References: <201901111552.x0BFqAxa049564@repo.freebsd.org> <201901111604.x0BG4XoU021904@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201901111604.x0BG4XoU021904@pdx.rh.CN85.dnsmgr.net> X-Editor: VIM - Vi IMproved 8.0 User-Agent: Mutt/1.11.1 (2018-12-01) X-Rspamd-Queue-Id: 6980A87FF3 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 21:04:46 -0000 On Fri, Jan 11, 2019 at 08:04:33AM -0800, Rodney W. Grimes wrote: > The style of this .sh does not match the normal style of > such things in base, especially with respect to long lines > and indentation. In addition to adding the license header and changing copyleft -> copyright I changed the indentation to tabs and wrapped around most lines at 80 chars: http://bsd-geek.de/FreeBSD/bluetooth-config.sh IMHO the original version was easier to read, but I will adhere to standards. :)