From owner-freebsd-arch Wed May 16 21:47:13 2001 Delivered-To: freebsd-arch@freebsd.org Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67]) by hub.freebsd.org (Postfix) with ESMTP id D869437B423; Wed, 16 May 2001 21:47:10 -0700 (PDT) (envelope-from dillon@earth.backplane.com) Received: (from dillon@localhost) by earth.backplane.com (8.11.3/8.11.2) id f4H4lA188014; Wed, 16 May 2001 21:47:10 -0700 (PDT) (envelope-from dillon) Date: Wed, 16 May 2001 21:47:10 -0700 (PDT) From: Matt Dillon Message-Id: <200105170447.f4H4lA188014@earth.backplane.com> To: "Brian F. Feldman" Cc: Alfred Perlstein , freebsd-arch@FreeBSD.ORG Subject: Re: Upgrading u_short cr_ref to u_int cr_ref in ucred on -stable References: <200105170442.f4H4gZf51783@green.bikeshed.org> Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG :> a little later I will throw an overflow check and panic into -current :> (and -stable in 3 days) as per Terry's suggestion. : :It would really be a good idea to do it instead of breaking the API :completely, I think. I've been meaning to test it all on 4.3 and commit it, :but I'm still finishing school. Finals time means too much worry and not :enough FreeBSD hacking :( It should be an easy change, though. : :-- : Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / Well, I agree on principle, but I don't think the changes to cr_ref breaks any existing programs (though obviously I can't be 100% sure). A much bigger problem is going to be Tor's O_DIRECT stuff... that requires the struct file's f_flag to go from short -> u_int. So far I haven't found anything that breaks. If it turns out to be an issue I can split the flags field into two shorts (there are unused shorts elsewhere in the structure). -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message