From owner-freebsd-ports@FreeBSD.ORG Mon May 16 19:47:01 2011 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DA48106564A; Mon, 16 May 2011 19:47:01 +0000 (UTC) (envelope-from db@db.net) Received: from diana.db.net (diana.db.net [66.113.102.10]) by mx1.freebsd.org (Postfix) with ESMTP id 460638FC12; Mon, 16 May 2011 19:47:01 +0000 (UTC) Received: from night.db.net (localhost [127.0.0.1]) by diana.db.net (Postfix) with ESMTP id D2ECE2283B; Mon, 16 May 2011 13:41:43 -0600 (MDT) Received: by night.db.net (Postfix, from userid 1000) id 7D48A709F; Mon, 16 May 2011 15:47:18 -0400 (EDT) Date: Mon, 16 May 2011 15:47:18 -0400 From: Diane Bruce To: Andriy Gapon Message-ID: <20110516194718.GA1818@night.db.net> References: <4DD0CC21.5050305@FreeBSD.org> <20110516120807.GA34582@night.db.net> <4DD1796F.2000305@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DD1796F.2000305@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: ports@FreeBSD.org, Eitan Adler , Diane Bruce Subject: Re: patch for force fetch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2011 19:47:01 -0000 On Mon, May 16, 2011 at 10:22:23PM +0300, Andriy Gapon wrote: > on 16/05/2011 19:53 Eitan Adler said the following: > >> I've run into this myself and simply done the manual rm -f. This looks like > >> a great addition. > > > > what about make distclean ? > > Can you please elaborate? > If you mean that I could just run 'make distclean', then my answer is why should > I. I.e. if the ports infrastructure already knows that there is something wrong > with a local copy of a distfile (wrong size, wrong checksum), then it should > just do the right thing and not annoy me to run some cleanup action. I agree. Moreover, I've been thinking about the fetch operation in ports for a while, discussed with linimon@ once. There should be a way to have a little more intelligence in that. e.g. if we are expecting a binary tarball and we get back a html file, we know something has gone wrong. One of these years. -- - db@FreeBSD.org db@db.net http://www.db.net/~db Why leave money to our children if we don't leave them the Earth?