Date: Tue, 23 May 1995 23:44:46 -0700 From: asami@cs.berkeley.edu (Satoshi Asami | =?ISO-2022-JP?B?GyRCQHUbKEI=?= =?ISO-2022-JP?B?GyRCOCsbKEIgGyRCOC0bKEI=?=) To: jhs@vector.eikon.e-technik.tu-muenchen.de Cc: jhs@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com Subject: Re: cvs commit: ports/comms/hylafax - Imported sources Message-ID: <199505240644.XAA03989@silvia.HIP.Berkeley.EDU> In-Reply-To: <199505222216.AAA07935@vector.eikon.e-technik.tu-muenchen.de> (message from Julian Howard Stacey on Tue, 23 May 1995 00:16:48 %2B0200)
next in thread | previous in thread | raw e-mail | index | archive | help
* > Julian, I asked you to send me a mail when you are done, not to commit it. * * That puzzled me, it contradicted what you had posted earlier, : * You had earlier written you wanted hylafax ( & had chased for it). * You had earlier written we were in code freeze _except for new ports_ * (go check your outgoing posting log if in doubt) That's why I asked you EXPLICITLY to NOT commit it after taking a look at the initial snapshot of your port. That is NOT commit material, and needs lots of cleanup. * > I haven't taken a look at any of your numerous * > auxiliary scripts and I haven't done any testing. * * Don't worry, `cd /usr/ports; make' does NOT use this tree yet You don't understand. If it doesn't work or if it's too messy, it doesn't belong there. Taking a port out of the SUBDIR list is the last resort to minimize the damage when something goes out of date or breaks, not a way to import a new port. :) * Unless you own & rely on a fax modem as I do, my actual software_in_use * as compiled, installed, & used on day of commit, is more `tested' anyway. I have never doubted it works for you. But that doesn't mean the port works for everybody. * If an md5 complains, & patches blow: consider the possibility the distfile * may have changed ! Don't just commit a new md5. Then explain this: % cat /e/work/asami/ports/comms/hylafax/files/md5 MD5 (hylafax-v3.0pl0-tar.gz) = 014ec8a64ea7493d26c50c61b5ef3111 % md5 ~jhs/hylafax-v3.0pl0-tar.gz /e/ports/distfiles/hylafax-v3.0pl0-tar.gz MD5 (/home/jhs/hylafax-v3.0pl0-tar.gz) = 014ec8a64ea7493d26c50c61b5ef3111 MD5 (/e/ports/distfiles/hylafax-v3.0pl0-tar.gz) = 014ec8a64ea7493d26c50c61b5ef3111 The files/md5 you committed doesn't even match what you have in your home directory! In fact, the md5 I committed matches yours. Also, the distfile on ftp.sgi.com has been there since April 9, if you have something else, that's really old. * > You haven't demonstrated you can maintain the port (see below), * * Totally Unfair ! You denied me any chance to ! * In the ~14 hours between commiting this & then getting the mail, first I was * asleep, then I was waiting for my mail link to restore itself. * You broke Hylafax by changing md5, & now accuse me of bad maintenance ! Hey don't read too much into my words, what I said was that you haven't demonstrated it (you haven't even given the chance yet!), I didn't say you failed or anything. I just can't trust you YET, okay? (I see it that this is the first port you made.) :) Making something work on your machine is one thing. Making that into a port that works on ANYBODY'S MACHINE is a totally different thing, especially for a port as complicated as hylafax. You probably should have tried something easier, not hylafax. * > I do NOT want a broken or messy port in the tree. * * No one wants broken ports. * You imply a messy port that works is not wanted ? Yes. It will be un-manageable in the future, and will be broken quickly. * Anyway first `messiness' was a workaround the broken handling of DISTNAME * in your area (share/mk/bsd.port.mk) * I'm glad to hear you've added EXTRACT_SUFX, I've had a quick look, It's still very messy even after I removed all the stuff about the -tar.gz suffix. ;) Anyway, I don't really see any solution to this, I can't even get it to compile on thud, so I'm sorry but I have to take this out. Satoshi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199505240644.XAA03989>