From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jan 25 18:23:46 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EDB81E2A for ; Sun, 25 Jan 2015 18:23:46 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BA5E53D6 for ; Sun, 25 Jan 2015 18:23:46 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t0PINkFm050400 for ; Sun, 25 Jan 2015 18:23:46 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197073] net/libsrtp should not require WITH_OPENSSL_PORT Date: Sun, 25 Jan 2015 18:23:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: mi@ALDAN.algebra.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Jan 2015 18:23:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197073 Bug ID: 197073 Summary: net/libsrtp should not require WITH_OPENSSL_PORT Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: mi@ALDAN.algebra.com CC: alexander@brovikov.ru CC: alexander@brovikov.ru Flags: maintainer-feedback?(alexander@brovikov.ru) Created attachment 152131 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=152131&action=edit Improve net/libsrtp, bump PORTREVISION Maybe, the port's OpenSSL is required on older releases, but requiring it unconditionally is a mistake -- the OpenSSL, that comes with FreeBSD-10.1, for example, is sufficient. The proposed patch removes the requirement and picks some other, lesser, nits: 1. Link the libsrtp.so with -lcrypto ITSELF -- instead of requiring all of the library's users to link with -lcrypto. 2. Build the library's static objects (.o-files) without -fPIC, but use the full -DPIC -fPIC sequence for building the objects, that are used to build the shared library (.So-files). 3. Build the shared library together with the rest -- in a single gmake- invocation -- rather than in post-build. 4. Add the regression-test-target (aliased as "test", "check", and "runtest") using the self-tests bundled with the library's sources. Please, allow committing... Thank you! --- Comment #1 from Bugzilla Automation --- Maintainer CC'd -- You are receiving this mail because: You are the assignee for the bug.