From owner-svn-src-head@freebsd.org  Thu Feb 23 18:30:13 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1B63CEBCB9;
 Thu, 23 Feb 2017 18:30:13 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7FA94698;
 Thu, 23 Feb 2017 18:30:13 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by mail.baldwin.cx (Postfix) with ESMTPSA id B87A910A7B9;
 Thu, 23 Feb 2017 13:30:05 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: "Pedro F. Giffuni" <pfg@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r314145 - in head/sys/dev/vxge: . vxgehal
Date: Thu, 23 Feb 2017 10:16:50 -0800
Message-ID: <114455088.Nuga6bxpH7@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; )
In-Reply-To: <201702231610.v1NGAGOK040762@repo.freebsd.org>
References: <201702231610.v1NGAGOK040762@repo.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Thu, 23 Feb 2017 13:30:05 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Feb 2017 18:30:13 -0000

On Thursday, February 23, 2017 04:10:16 PM Pedro F. Giffuni wrote:
> Author: pfg
> Date: Thu Feb 23 16:10:15 2017
> New Revision: 314145
> URL: https://svnweb.freebsd.org/changeset/base/314145
> 
> Log:
>   dev/vxe: double assignments.
>   
>   Fix some suspicious code, likely caused by excessive copy-pasting.
>   
>   Found with:	coccinelle (da.cocci)
>   MFC after:	2 weeks
> 
> Modified:
>   head/sys/dev/vxge/vxge.c
>   head/sys/dev/vxge/vxgehal/vxgehal-config.c
> 
> Modified: head/sys/dev/vxge/vxge.c
> ==============================================================================
> --- head/sys/dev/vxge/vxge.c	Thu Feb 23 16:07:45 2017	(r314144)
> +++ head/sys/dev/vxge/vxge.c	Thu Feb 23 16:10:15 2017	(r314145)
> @@ -2312,7 +2312,7 @@ vxge_vpath_open(vxge_dev_t *vdev)
>  		vpath->rx_ticks = ticks;
>  
>  		vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL;
> -		vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL;
> +		vpath->rti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL;

Probably use VXGE_DEFAULT_<R>TI_RTIMER_VAL instead of <T>TI?

-- 
John Baldwin