From owner-svn-src-all@FreeBSD.ORG Sat Jun 18 14:36:09 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F173106566C; Sat, 18 Jun 2011 14:36:09 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail07.syd.optusnet.com.au (mail07.syd.optusnet.com.au [211.29.132.188]) by mx1.freebsd.org (Postfix) with ESMTP id 1177E8FC08; Sat, 18 Jun 2011 14:36:08 +0000 (UTC) Received: from c122-106-165-191.carlnfd1.nsw.optusnet.com.au (c122-106-165-191.carlnfd1.nsw.optusnet.com.au [122.106.165.191]) by mail07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id p5IEa6Yf008814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 19 Jun 2011 00:36:07 +1000 Date: Sun, 19 Jun 2011 00:36:06 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Ben Laurie In-Reply-To: <201106181356.p5IDuXhW044171@svn.freebsd.org> Message-ID: <20110619000207.V7011@besplex.bde.org> References: <201106181356.p5IDuXhW044171@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223262 - in head: cddl/contrib/opensolaris/lib/libdtrace/common contrib/binutils/bfd contrib/binutils/gas contrib/binutils/gas/config contrib/binutils/ld contrib/binutils/opcodes contr... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jun 2011 14:36:09 -0000 On Sat, 18 Jun 2011, Ben Laurie wrote: > Author: benl > Date: Sat Jun 18 13:56:33 2011 > New Revision: 223262 > URL: http://svn.freebsd.org/changeset/base/223262 > > Log: > Fix clang warnings. > > Approved by: philip (mentor) Most of these seem to be bugs in clang, so source code can only be broken by avoiding the warnings there. In particular: - casting to void is a large style bug in gnu code. Warnings in vendor code shouldn't be fixed anyway. - it is an old gcc bug to warn about use of the extremely unsurprising precedence of AND operators over OR operators. This bug is not much of a problem since it is controlled by -Wparentheses. -Wparentheses is impiled by -Wall, which is enables at WARNS >= 2. But it is a new clang bug to make this warning unconditional (it can be turned off or configured off, but this is not supported in FreeBSD or documented in clang.1). So it is now fatal at WARNS >=1, since WARNS >=1 turns warnings into errors. Bruce