From owner-cvs-all Sat Sep 8 14:53: 0 2001 Delivered-To: cvs-all@freebsd.org Received: from peter3.wemm.org (c1315225-a.plstn1.sfba.home.com [24.14.150.180]) by hub.freebsd.org (Postfix) with ESMTP id 394A837B405; Sat, 8 Sep 2001 14:52:55 -0700 (PDT) Received: from overcee.netplex.com.au (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id f88LqtM57457; Sat, 8 Sep 2001 14:52:55 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id D8BCD380A; Sat, 8 Sep 2001 14:52:54 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Josef Karthauser Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: CVSROOT cfg.pm commit_prep.pl In-Reply-To: <200109080211.f882BZt86733@freefall.freebsd.org> Date: Sat, 08 Sep 2001 14:52:54 -0700 From: Peter Wemm Message-Id: <20010908215254.D8BCD380A@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Josef Karthauser wrote: > joe 2001/09/07 19:11:35 PDT > > Modified files: > . cfg.pm commit_prep.pl > Log: > Add code to unexpand $FreeBSD: xxxx $ (or whatever is defined in > the config file as being our $IDHEADER$) upon commit. This is useful > to avoid a '+1 -1' delta against the version string. This is broken, it happens before the $Id$ spamming checks. You only want this to be run after all the sanity checks are done. Of course then you have to fix all the return's from the function. :-) In fact, it should probably go after the &check_version() call, not inside check_version itself. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message