From owner-freebsd-new-bus Thu Mar 16 1: 3:30 2000 Delivered-To: freebsd-new-bus@freebsd.org Received: from anchor-post-34.mail.demon.net (anchor-post-34.mail.demon.net [194.217.242.92]) by hub.freebsd.org (Postfix) with ESMTP id B758737B794 for ; Thu, 16 Mar 2000 01:03:24 -0800 (PST) (envelope-from dfr@nlsystems.com) Received: from nlsys.demon.co.uk ([158.152.125.33] helo=herring.nlsystems.com) by anchor-post-34.mail.demon.net with esmtp (Exim 2.12 #1) id 12VWBb-000Ajn-0Y; Thu, 16 Mar 2000 09:03:19 +0000 Received: from salmon.nlsystems.com (salmon.nlsystems.com [10.0.0.3]) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id JAA35449; Thu, 16 Mar 2000 09:02:14 GMT (envelope-from dfr@nlsystems.com) Date: Thu, 16 Mar 2000 09:08:48 +0000 (GMT) From: Doug Rabson To: Nick Hibma Cc: FreeBSD Newbus Mailing List Subject: Re: Patch for review In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-new-bus@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 15 Mar 2000, Nick Hibma wrote: > > The attached patch removes the use of nextunit and replaces it with a > linear search for the first element available. > > This avoids the unit number from ever increasing and memory being wasted > if you unplug & plug two devices alternatingly. Good. > > It also flags that we have called DEVICE_NOMATCH and should not call it > again during a reprobe. > > Let me know if this is anything you would not like to see implemented. I was working around this by putting "if (!cold) return" in pci_nomatch but this is cleaner. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-new-bus" in the body of the message