From owner-svn-src-all@freebsd.org Tue Apr 18 19:15:24 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC852D44FA0; Tue, 18 Apr 2017 19:15:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 81B1E171; Tue, 18 Apr 2017 19:15:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wm0-f47.google.com with SMTP id r190so11643635wme.1; Tue, 18 Apr 2017 12:15:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=y5khROLhd0BWHV2RSWuODWTQux+975iig3YwGcfKvpo=; b=DaGgUGjhcKVtDVSejrcVyK9JSM9N7r1JUrnfrtKdbkcD97rtJvqyjQxmnblBIUPD5B zHIKA9gJvGXm41ywhuHBfM0jQozjHcibG84Jw3O902Er8UBcXXsTxu15nWIe9UegCcYr uRYtxkIO3tcUCeOAC3raVDTeYeCydxowm+/y7fZniFGPS0IFPwpQtgx77Q+OLxPNuQxY 3dRD01KCuFQDkNAH7N/gYK7VRSr1T4TZWX5UOcjPDXUh/NmmDmvE7BlXTONPKJWaEaiX 7I/GDB0Gb1yE8wMx53PH4bbJjPgtKNVWOKlAnIpSb0/x0JOBKabAC80jiaLwoccNn38p 2XlQ== X-Gm-Message-State: AN3rC/7+JW+epPcUFLvKxOVTmiYOCm35q0WluKgNWP/bdIjGUXNkJcq6 tGUPb0ECVIzCnVC64T0= X-Received: by 10.28.209.204 with SMTP id i195mr14890499wmg.113.1492542922048; Tue, 18 Apr 2017 12:15:22 -0700 (PDT) Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id m83sm16198001wmc.7.2017.04.18.12.15.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Apr 2017 12:15:21 -0700 (PDT) Received: by mail-wr0-f177.google.com with SMTP id z109so1497359wrb.1; Tue, 18 Apr 2017 12:15:21 -0700 (PDT) X-Received: by 10.223.160.214 with SMTP id n22mr26036844wrn.198.1492542921770; Tue, 18 Apr 2017 12:15:21 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.80.169.4 with HTTP; Tue, 18 Apr 2017 12:15:21 -0700 (PDT) In-Reply-To: References: <201610312309.u9VN9qGk027956@repo.freebsd.org> From: Conrad Meyer Date: Tue, 18 Apr 2017 12:15:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r308155 - in head/sys: amd64/conf cam cam/scsi conf dev/mps geom geom/part kern sys vm To: Alan Somers Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 19:15:25 -0000 Hi Alan, On Tue, Apr 18, 2017 at 12:02 PM, Alan Somers wrote: > This change is causing panics when I try to create a zpool on an SSD. > > ... (reordered slightly) > > The > offending line is the biotrack call in scsi_da.c at line 4172; bp is > apparently null. Could you please review this change and ensure that > biotrack is appropriately guarded? If it is valid for bp to be NULL in that path, then of course a NULL guard needs to be added. I'm a little confused on why or if it is valid for bp to be NULL in that path. You are the only one who has reported this since October of last year. Is it possible some other issue is now resulting in a NULL bp? > The SSD is obviously having problems; it fails UNMAP commands with > ILLEGAL REQUEST, and then fails WRITE SAME with a timeout. Well, that could definitely explain a weird error case. Still, shouldn't the CCB keep the bp associated through CCB completion? Thanks, Conrad