From owner-svn-src-all@freebsd.org Wed Jun 6 20:36:05 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC7A7FE2495; Wed, 6 Jun 2018 20:36:04 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 727EF86A63; Wed, 6 Jun 2018 20:36:04 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w56KZiZZ006722; Wed, 6 Jun 2018 13:35:44 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w56KZhV8006721; Wed, 6 Jun 2018 13:35:43 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201806062035.w56KZhV8006721@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r334617 - in head: . etc In-Reply-To: <1528311745.474139.1398838488.1527C06D@webmail.messagingengine.com> To: Brad Davis Date: Wed, 6 Jun 2018 13:35:43 -0700 (PDT) CC: rgrimes@freebsd.org, Konstantin Belousov , Eugene Grosbein , Alexander Leidinger , Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jun 2018 20:36:05 -0000 > On Wed, Jun 6, 2018, at 12:33 PM, Rodney W. Grimes wrote: > > > > > > On Tue, Jun 5, 2018, at 1:28 PM, Konstantin Belousov wrote: > > > > On Wed, Jun 06, 2018 at 01:39:00AM +0700, Eugene Grosbein wrote: > > > > > 06.06.2018 1:26, Konstantin Belousov wrote: > > > > > > > > > > >>> I find it often very useful to do > > > > > >>> (cd src/etc/rc.d && make install) > > > > > >>> Same for defaults and several other directories which in fact > > > > > >>> contains> > >>> non-editable content. Is this planned to keep working ? > > > > > >> > > > > > >> The short answer is, no. All rc.d scripts get moved to the src > > > > > >> of the program they start.> > >> > > > > > >> That said, if there is a big need for this, we can see about > > > > > >> options to keep them working.> > >> > > > > > >> What are you trying to accomplish when you do this? Just verify > > > > > >> the rc.d scripts match your src tree?> > > > > > > > > I avoid mergemaster/etcupdate and whatever else. rc.d and /etc/rc,> > > /etc/rc.subr /etc/rc.network are not suitable to etc, they are > > > > > > binaries> > > provided by the project not for the user editing. > > > > > > > > > > > > When upgrading the host, esp. on HEAD, i usually refresh scripts > > > > > > by this> > > procedure and avoid any editing and implied conflict resolution > > > > > > for real> > > configs. > > > > > > > > > > > > Not being able to easily install clean copies of these scripts > > > > > > would> > > be very inconvenient and time consuming. > > > > > > > > > > I found that "mergemaster -iFUP" deals with unchanged files > > > > > including mentioned rc* scripts just fine.> > That is, it automatically refreshes unchanged files without any > > > > > silly questions just for change of $FreeBSD$.> > > > > No, you missed the point. Whatever nice is the handling of > > > > unchanged files,> use of mergemaster forces me to handle changed files, which is exactly> what I do not want/need to do. Yes, I update crashboxes very > > > > often, and> I want to get all new code, including the startup scripts, when > > > > I update. > > > The startup scripts will be installed as part of installworld. > > > > So each installworld would wipe over the top of any localmod /etc/rc.d/ > > and other stuff > > that mght exist? > > One of the reasons that etc/Makefile is detached from Installword is so > > that > > /etc does not get perturbuted unless specifically requested. > > Yes, this is by design. This is going to have a great amount of push back, and this is by your NEW design, the existing design does not cause this pain. > > If people need custom tweaks for that stuff they should be upstreamed or moved into /usr/local/etc/rc.d as a custom startup script. I doubt very much this is a practical solution. I have changes that I doubt belong in FreeBSD, and are not restricted to etc/rc.d. And from reading this thread thus far so do others. -- Rod Grimes rgrimes@freebsd.org