From owner-freebsd-fs@FreeBSD.ORG  Wed Jun  6 18:39:58 2012
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 09A7E1065676;
	Wed,  6 Jun 2012 18:39:58 +0000 (UTC)
	(envelope-from kostikbel@gmail.com)
Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200])
	by mx1.freebsd.org (Postfix) with ESMTP id 5F39F8FC08;
	Wed,  6 Jun 2012 18:39:57 +0000 (UTC)
Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1])
	by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q56IdoaO057089;
	Wed, 6 Jun 2012 21:39:50 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1])
	by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id
	q56Idng5022856; Wed, 6 Jun 2012 21:39:49 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
Received: (from kostik@localhost)
	by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q56Idn4E022855; 
	Wed, 6 Jun 2012 21:39:49 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to
	kostikbel@gmail.com using -f
Date: Wed, 6 Jun 2012 21:39:49 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20120606183949.GR85127@deviant.kiev.zoral.com.ua>
References: <201203071318.08241.jhb@freebsd.org>
	<201203091059.29342.jhb@freebsd.org>
	<201203161406.27549.jhb@freebsd.org>
	<201206060817.54684.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="im83/wVv0jiGQj4J"
Content-Disposition: inline
In-Reply-To: <201206060817.54684.jhb@freebsd.org>
User-Agent: Mutt/1.4.2.3i
X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00
	autolearn=ham version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
	skuns.kiev.zoral.com.ua
Cc: freebsd-fs@freebsd.org, pho@freebsd.org
Subject: Re: close() of an flock'd file is not atomic
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jun 2012 18:39:58 -0000


--im83/wVv0jiGQj4J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 06, 2012 at 08:17:54AM -0400, John Baldwin wrote:
> Based on feedback from Konstantin, I have split the vn_open_vnode() chang=
es
> out into a separate patch.  Once that patch is in the tree I will revisit
> this and update the actual bug-fix patch.
>=20
> The vn_open_vnode() patch is at
> http://www.freebsd.org/~jhb/patches/vn_open_vnode.patch
>=20
> I tested it by doing a buildworld -j 32 in a loop while NFS exporting the
> /usr/obj tree to another machine that did a continual find | xargs md5 lo=
op
> over the /usr/obj tree.  This survived overnight.

There is #if 0 left in fhopen() which translates ERESTART into EINTR. Is
it needed ?

Otherwise it looks fine (but still quite hard to read).


--im83/wVv0jiGQj4J
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)

iEYEARECAAYFAk/Po/UACgkQC3+MBN1Mb4iWTgCdFuHxkGYMpxn4NuorK/BUAotw
hX4An1rW4uWY9b4v1e8Jex037CeeZ8XY
=dcfI
-----END PGP SIGNATURE-----

--im83/wVv0jiGQj4J--