From owner-freebsd-hackers@FreeBSD.ORG Tue Mar 4 20:05:18 2008 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B48011065674 for ; Tue, 4 Mar 2008 20:05:18 +0000 (UTC) (envelope-from SRS0+fba8d5d6a16a8717fea7+1654+infradead.org+hch@bombadil.srs.infradead.org) Received: from bombadil.infradead.org (unknown [IPv6:2001:4830:2446:ff00:214:51ff:fe65:c65c]) by mx1.freebsd.org (Postfix) with ESMTP id 5A8178FC20 for ; Tue, 4 Mar 2008 20:05:18 +0000 (UTC) (envelope-from SRS0+fba8d5d6a16a8717fea7+1654+infradead.org+hch@bombadil.srs.infradead.org) Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1JWdNd-0004od-5p; Tue, 04 Mar 2008 20:04:53 +0000 Date: Tue, 4 Mar 2008 15:04:53 -0500 From: Christoph Hellwig To: "M. Warner Losh" Message-ID: <20080304200453.GA10987@infradead.org> References: <20080303.224256.635730757.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080303.224256.635730757.imp@bsdimp.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Cc: hackers@freebsd.org Subject: Re: Comments on pmake diffs for building on Linux X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 20:05:18 -0000 On Mon, Mar 03, 2008 at 10:42:56PM -0700, M. Warner Losh wrote: > +#ifndef TAILQ_HEAD_INITIALIZER > +#define TAILQ_HEAD_INITIALIZER(head) { NULL, &(head).tqh_first } > +#endif > + > +#ifndef TAILQ_FOREACH > +#define TAILQ_FOREACH(var, head, field) \ > + for ((var) = TAILQ_FIRST((head)); \ > + (var); \ > + (var) = TAILQ_NEXT((var), field)) > +#endif ... I think you might be better off with a shadow include/ directory that provides a current sys/queue.h on Linux which is what quite a few other packages do. I've tried updating the on in glibc a few years ago but the maintainer refused to take it.