From owner-svn-src-all@FreeBSD.ORG Mon Oct 24 14:42:33 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F05091065670; Mon, 24 Oct 2011 14:42:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 675F68FC0C; Mon, 24 Oct 2011 14:42:32 +0000 (UTC) Received: from alf.home (alf.kiev.zoral.com.ua [10.1.1.177]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p9OEgSCi050482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 24 Oct 2011 17:42:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from alf.home (kostik@localhost [127.0.0.1]) by alf.home (8.14.5/8.14.5) with ESMTP id p9OEgSJD089521; Mon, 24 Oct 2011 17:42:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by alf.home (8.14.5/8.14.5/Submit) id p9OEgSli089520; Mon, 24 Oct 2011 17:42:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: alf.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 24 Oct 2011 17:42:28 +0300 From: Kostik Belousov To: Roman Divacky Message-ID: <20111024144228.GL50300@deviant.kiev.zoral.com.ua> References: <201110241353.p9ODrW99046445@svn.freebsd.org> <20111024142245.GA73120@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dYbRCasfhpyZLUd7" Content-Disposition: inline In-Reply-To: <20111024142245.GA73120@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226687 - head/sys/fs/nullfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2011 14:42:34 -0000 --dYbRCasfhpyZLUd7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 24, 2011 at 04:22:45PM +0200, Roman Divacky wrote: > On Mon, Oct 24, 2011 at 01:53:32PM +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Mon Oct 24 13:53:32 2011 > > New Revision: 226687 > > URL: http://svn.freebsd.org/changeset/base/226687 > >=20 > > Log: > > The only possible error return from null_nodeget() is due to insmntqu= e1 > > failure (the getnewvnode cannot return an error). In this case, the > > null_insmntque_dtr() already unlocked the reclaimed vnode, so VOP_UNL= OCK() > > in the nullfs_mount() after null_nodeget() failure is wrong. > > =20 > > Tested by: pho > > MFC after: 1 week > >=20 > > Modified: > > head/sys/fs/nullfs/null_vfsops.c > >=20 > > Modified: head/sys/fs/nullfs/null_vfsops.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/fs/nullfs/null_vfsops.c Mon Oct 24 13:48:13 2011 (r226686) > > +++ head/sys/fs/nullfs/null_vfsops.c Mon Oct 24 13:53:32 2011 (r226687) > > @@ -157,7 +157,6 @@ nullfs_mount(struct mount *mp) > > * Make sure the node alias worked > > */ > > if (error) { > > - VOP_UNLOCK(vp, 0); >=20 > Maybe you want to assert that it's indeed unlocked at this point? No, I don't, since the vnode pointer is already invalid at this point. The vput() call in dtr released the vnode reference owned by current thread. --dYbRCasfhpyZLUd7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk6leVQACgkQC3+MBN1Mb4ibCwCfRusCwPjeHfURw4eduKBaKgkR E7sAoLjo+IQl7ju/dSeagnxYoxzk35A/ =rR/d -----END PGP SIGNATURE----- --dYbRCasfhpyZLUd7--