From owner-svn-src-all@FreeBSD.ORG Sat Jun 11 01:19:19 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D908F106566B; Sat, 11 Jun 2011 01:19:19 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id C99B88FC08; Sat, 11 Jun 2011 01:19:19 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p5B1JJU5051647; Sat, 11 Jun 2011 01:19:19 GMT (envelope-from delphij@svn.freebsd.org) Received: (from delphij@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id p5B1JJP9051645; Sat, 11 Jun 2011 01:19:19 GMT (envelope-from delphij@svn.freebsd.org) Message-Id: <201106110119.p5B1JJP9051645@svn.freebsd.org> From: Xin LI Date: Sat, 11 Jun 2011 01:19:19 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r222967 - head/sys/dev/atkbdc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jun 2011 01:19:19 -0000 Author: delphij Date: Sat Jun 11 01:19:19 2011 New Revision: 222967 URL: http://svn.freebsd.org/changeset/base/222967 Log: Add comments about the validation. Modified: head/sys/dev/atkbdc/atkbd.c Modified: head/sys/dev/atkbdc/atkbd.c ============================================================================== --- head/sys/dev/atkbdc/atkbd.c Sat Jun 11 00:31:37 2011 (r222966) +++ head/sys/dev/atkbdc/atkbd.c Sat Jun 11 01:19:19 2011 (r222967) @@ -1097,6 +1097,15 @@ get_typematic(keyboard_t *kbd) x86regs_t regs; uint8_t *p; + /* + * Traditional entry points of int 0x15 and 0x16 are fixed + * and later BIOSes follow them. (U)EFI CSM specification + * also mandate these fixed entry points. + * + * Validate the entry points here before we proceed further. + * It's known that some recent laptops does not have the + * same entry point and hang on boot if we call it. + */ if (x86bios_get_intr(0x15) != 0xf000f859 || x86bios_get_intr(0x16) != 0xf000e82e) return (ENODEV);