Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Jun 2011 01:19:19 +0000 (UTC)
From:      Xin LI <delphij@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r222967 - head/sys/dev/atkbdc
Message-ID:  <201106110119.p5B1JJP9051645@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: delphij
Date: Sat Jun 11 01:19:19 2011
New Revision: 222967
URL: http://svn.freebsd.org/changeset/base/222967

Log:
  Add comments about the validation.

Modified:
  head/sys/dev/atkbdc/atkbd.c

Modified: head/sys/dev/atkbdc/atkbd.c
==============================================================================
--- head/sys/dev/atkbdc/atkbd.c	Sat Jun 11 00:31:37 2011	(r222966)
+++ head/sys/dev/atkbdc/atkbd.c	Sat Jun 11 01:19:19 2011	(r222967)
@@ -1097,6 +1097,15 @@ get_typematic(keyboard_t *kbd)
 	x86regs_t regs;
 	uint8_t *p;
 
+	/*
+	 * Traditional entry points of int 0x15 and 0x16 are fixed
+	 * and later BIOSes follow them.  (U)EFI CSM specification
+	 * also mandate these fixed entry points.
+	 *
+	 * Validate the entry points here before we proceed further.
+	 * It's known that some recent laptops does not have the
+	 * same entry point and hang on boot if we call it.
+	 */
 	if (x86bios_get_intr(0x15) != 0xf000f859 ||
 	    x86bios_get_intr(0x16) != 0xf000e82e)
 		return (ENODEV);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201106110119.p5B1JJP9051645>