From owner-p4-projects@FreeBSD.ORG  Sun Nov 25 23:48:12 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 17B8A16A47E; Sun, 25 Nov 2007 23:48:12 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B14CF16A47A
	for <perforce@freebsd.org>; Sun, 25 Nov 2007 23:48:11 +0000 (UTC)
	(envelope-from kmacy@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 9C53113C478
	for <perforce@freebsd.org>; Sun, 25 Nov 2007 23:48:11 +0000 (UTC)
	(envelope-from kmacy@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lAPNmB5X051701
	for <perforce@freebsd.org>; Sun, 25 Nov 2007 23:48:11 GMT
	(envelope-from kmacy@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lAPNmB4i051692
	for perforce@freebsd.org; Sun, 25 Nov 2007 23:48:11 GMT
	(envelope-from kmacy@freebsd.org)
Date: Sun, 25 Nov 2007 23:48:11 GMT
Message-Id: <200711252348.lAPNmB4i051692@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	kmacy@freebsd.org using -f
From: Kip Macy <kmacy@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 129523 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Nov 2007 23:48:12 -0000

http://perforce.freebsd.org/chv.cgi?CH=129523

Change 129523 by kmacy@kmacy:storage:toestack on 2007/11/25 23:48:11

	fix test_and_clear to have the intended effect of tested and clearing 
	a bit by index

Affected files ...

.. //depot/projects/toestack/sys/dev/cxgb/cxgb_osdep.h#11 edit

Differences ...

==== //depot/projects/toestack/sys/dev/cxgb/cxgb_osdep.h#11 (text+ko) ====

@@ -299,7 +299,7 @@
 
 #define t3_os_sleep(x) DELAY((x) * 1000)
 
-#define test_and_clear_bit(bit, p) atomic_cmpset_int((p), ((*(p)) | bit), ((*(p)) & ~bit)) 
+#define test_and_clear_bit(bit, p) atomic_cmpset_int((p), ((*(p)) | (1<<bit)), ((*(p)) & ~(1<<bit)))
 
 #define max_t(type, a, b) (type)max((a), (b))
 #define net_device ifnet