Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Jun 2008 10:20:08 +0200 (CEST)
From:      Helge Oldach <ports-audio-flac-jun08@oldach.net>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        naddy@FreeBSD.org
Subject:   ports/124181: [patch] enable audio/flac WITHOUT_ICONV
Message-ID:  <200806010820.m518K8kw026609@sep.oldach.net>
Resent-Message-ID: <200806010830.m518U3rE025589@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         124181
>Category:       ports
>Synopsis:       [patch] enable audio/flac WITHOUT_ICONV
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 01 08:30:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Helge Oldach
>Release:        FreeBSD 6.3-1230 i386
>Organization:
>Environment:

System: FreeBSD localhost 6.3-1230 FreeBSD 6.3-1230 #0: Tue May 20 17:05:20 CEST 2008 toor@localhost:/usr/obj/usr/src/sys/HMO i386

>Description:

audio/flac can work without libiconv installed (for those who want to
avoid linkage and dependency bloat).

>How-To-Repeat:

>Fix:

--- Makefile.ctm	2008-04-08 14:58:12.000000000 +0200
+++ Makefile	2008-06-01 10:07:52.000000000 +0200
@@ -17,16 +17,21 @@
 LIB_DEPENDS=	ogg.5:${PORTSDIR}/audio/libogg
 
 USE_AUTOTOOLS=	libtool:15
-USE_ICONV=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_TARGET=	--target=${ARCH}-unknown-freebsd${OSREL}
 CONFIGURE_ARGS=	--enable-sse \
-		--with-libiconv-prefix="${LOCALBASE}" \
 		--with-ogg="${LOCALBASE}" \
 		--disable-thorough-tests \
 		--disable-xmms-plugin
 CONFIGURE_ENV=	CPPFLAGS="-I${WRKSRC}/include"
 
+.if defined(WITHOUT_ICONV)
+CONFIGURE_ARGS+=--without-libiconv-prefix
+.else
+USE_ICONV=	yes
+CONFIGURE_ARGS+=--with-libiconv-prefix="${LOCALBASE}"
+.endif
+
 MAKE_ARGS=	pkgconfigdir="${PREFIX}/libdata/pkgconfig"
 MAKE_ENV=	MAKEOBJDIR=/nonexistent		# ignore ${WRKSRC}/obj
 .if defined(NOPORTDOCS)

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806010820.m518K8kw026609>