From owner-svn-src-head@freebsd.org Tue May 28 14:34:19 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E503E159E9FC; Tue, 28 May 2019 14:34:18 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 85F2383D5C; Tue, 28 May 2019 14:34:18 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 5AE1ADD04; Tue, 28 May 2019 14:34:18 +0000 (UTC) Date: Tue, 28 May 2019 14:34:18 +0000 From: Alexey Dokuchaev To: rgrimes@freebsd.org Cc: Konstantin Belousov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232071 - head/sys/vm Message-ID: <20190528143418.GA86669@FreeBSD.org> References: <20190527164056.GA17917@FreeBSD.org> <201905272134.x4RLY9oO012473@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201905272134.x4RLY9oO012473@gndrsh.dnsmgr.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 85F2383D5C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.92 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.92)[-0.925,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 May 2019 14:34:19 -0000 On Mon, May 27, 2019 at 02:34:09PM -0700, Rodney W. Grimes wrote: > I do not at all mean to discourage what you are doing, it is good to go > over static analysis reports, the problem is that there are often many > false positives, There are tons of them indeed, but that's normal for any static analysis tool. I've attempted to clean up the original log by ignoring the most noisy and dubious diagnostics and maintaining false positives list, starting with the ones pointed out by kib@. > It would be nice if we had a "team" that looked at all the Coverity > data, and any other data like what you have offered up here. Part of > the problem is that few want to do that work, or those that do want to > think it is low hanging fruit that anyone can do. That's exactly right, generating the check log is easy, finding people motivated enough to triage it (or finding the motivation within oneself) is tough. Maybe this ~2.4k line log would attract more interest than the first raw, full >16k line one: freefall:/home/danfe/pvs-kernel-filtered-2019-05-28.log.xz I'd appreciate if experts in their areas (cam/scsi, dev drivers, geom, kern, netinet, nfs, etc.) glanced over and see if they might help with anything there. If you find a false positive, please tell me so I can add it to the ignore list. Thanks! ./danfe