Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Jul 2022 00:19:51 GMT
From:      Po-Chuan Hsieh <sunpoet@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: d7ec4632b50c - main - databases/rocksdb: Try to find the reason why it is broken on our package building clusters
Message-ID:  <202207130019.26D0JpOt009461@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by sunpoet:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d7ec4632b50c4102ae08342d8b53ec9881e73f76

commit d7ec4632b50c4102ae08342d8b53ec9881e73f76
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2022-07-13 00:19:05 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-07-13 00:19:05 +0000

    databases/rocksdb: Try to find the reason why it is broken on our package building clusters
    
    - Locate all shared libraries before running strip
    - Clean up Makefile:
      - Use INSTALL_LIB to install librocksdb_tools.so
      - Remove PKGNAMESUFFIX: it is no-op after decouple rocksdb-lite from rocksdb
        (09bd0656bb445fed1675360acc33460e6d6fde44 and e4bc1f63b9dbdbde2463e8e4e33687aceb51bf1e)
    
    from poudriere log [1]:
    ...
      CCLD     librocksdb.so.7.3.1
    ln -fs librocksdb.so.7.3.1 librocksdb.so.7.3
    ln -fs librocksdb.so.7.3.1 librocksdb.so.7
    ln -fs librocksdb.so.7.3.1 librocksdb.so
    ...
    [ -e librocksdb.so.7.3.1 ] && gmake install-shared || :
    ...
    /usr/bin/strip /wrkdirs/usr/ports/databases/rocksdb/work/stage/usr/local/lib/librocksdb.so /wrkdirs/usr/ports/databases/rocksdb/work/stage/usr/local/lib/librocksdb_tools.so
    strip: open /wrkdirs/usr/ports/databases/rocksdb/work/stage/usr/local/lib/librocksdb.so failed: No such file or directory
    *** Error code 1
    
    Stop.
    make: stopped in /usr/ports/databases/rocksdb
    
    Reference:      http://beefy2.nyi.freebsd.org/data/123amd64-quarterly/3dc475798ba8/logs/rocksdb-7.3.1.log [1]
---
 databases/rocksdb/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/databases/rocksdb/Makefile b/databases/rocksdb/Makefile
index 59f10bcaf383..9a8767f9ab33 100644
--- a/databases/rocksdb/Makefile
+++ b/databases/rocksdb/Makefile
@@ -73,8 +73,10 @@ post-patch:
 post-install:
 	${MKDIR} ${STAGEDIR}${DATADIR}/
 	cd ${WRKSRC}/ && ${INSTALL_PROGRAM} ${BENCHMARKS} ${TOOLS} ${STAGEDIR}${PREFIX}/bin/
-	${INSTALL_DATA} ${WRKSRC}/librocksdb${PKGNAMESUFFIX}_tools.so ${STAGEDIR}${PREFIX}/lib/
-	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/librocksdb${PKGNAMESUFFIX}.so ${STAGEDIR}${PREFIX}/lib/librocksdb${PKGNAMESUFFIX}_tools.so
+	# Locate all shared libraries. The STRIP_CMD below failed on our package building clusters.
+	${FIND} ${WRKSRC} ${STAGEDIR}${PREFIX} -name '*.so*'
+	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/librocksdb.so
+	${INSTALL_LIB} ${WRKSRC}/librocksdb_tools.so ${STAGEDIR}${PREFIX}/lib/
 	${INSTALL_DATA} ${WRKSRC}/make_config.mk ${STAGEDIR}${DATADIR}/
 
 .include <bsd.port.post.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202207130019.26D0JpOt009461>