From owner-freebsd-current Mon Mar 11 07:11:36 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id HAA13798 for current-outgoing; Mon, 11 Mar 1996 07:11:36 -0800 (PST) Received: from deep-thought.demos.su (root@deep-thought.demos.su [194.87.1.76]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id HAA13770 for ; Mon, 11 Mar 1996 07:11:25 -0800 (PST) Received: by deep-thought.demos.su id RAA00748; (8.7.4/D) Mon, 11 Mar 1996 17:57:19 +0300 (MSK) To: current@freebsd.org, mark@grondar.za Message-ID: Organization: DEMOS Date: Mon, 11 Mar 1996 17:57:18 +0300 (MSK) X-Mailer: Mail/@ [v2.40 FreeBSD] From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (aka Andrey A. Chernov, Black Mage) X-Class: Fast Subject: secure/lib/libtelnet/Makefile and #ifdef comments Lines: 29 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk There was simple #ifdef comment that don't hurt anybody in old days (it left from original telnet Makefiles), what happens now: .if defined(MAKE_EBONES) CFLAGS+= -DENCRYPTION .if exists(${DESTDIR}/usr/lib/libkrb.a) && defined(MAKE_EBONES) ENCRYPTION *can* be defined *without* MAKE_EBONES, encryption can be RSA, etc and not related to EBONES directly, it is wrong move. BTW, why is double MAKE_EBONES now? nocrypt: .if defined(ENCRYPTION) @for i in ${CRYPT_SRC}; do \ Yet one again: nobody define ENCRYPTION variable, such variable not exists. I don't see any logic here. There is two solutions exists: finally cleanup telnet/telnetd/libtelnet makefiles moving them to FreeBSD variant only or back out libtelnet change. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - http://dt.demos.su/~ache : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849