From owner-freebsd-current@FreeBSD.ORG Fri Oct 29 08:00:19 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4688C16A4CE for ; Fri, 29 Oct 2004 08:00:19 +0000 (GMT) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9731F43D31 for ; Fri, 29 Oct 2004 08:00:18 +0000 (GMT) (envelope-from sos@DeepCore.dk) Received: from [194.192.25.143] (laptop.deepcore.dk [194.192.25.143]) by spider.deepcore.dk (8.12.11/8.12.10) with ESMTP id i9T7xNQ0014767; Fri, 29 Oct 2004 09:59:26 +0200 (CEST) (envelope-from sos@DeepCore.dk) Message-ID: <4181F86C.6050807@DeepCore.dk> Date: Fri, 29 Oct 2004 09:59:40 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= User-Agent: Mozilla Thunderbird 0.7.2 (X11/20040802) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jake Khuon References: <200410290736.i9T7aIia017214@Espresso.NEEBU.Net> In-Reply-To: <200410290736.i9T7aIia017214@Espresso.NEEBU.Net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-mail-scanned: by DeepCore Virus & Spam killer v1.4 cc: Bruce M Simpson cc: freebsd-current@freebsd.org Subject: Re: broken APM on IBM-T30 with 6.0-CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2004 08:00:19 -0000 Jake Khuon wrote: > ### On Thu, 28 Oct 2004 17:38:52 -0700, Bruce M Simpson > ### casually decided to expound upon Jake Khuon the > ### following thoughts about "Re: broken APM on IBM-T30 with 6.0-CURREN= T": >=20 > BMS> On Thu, Oct 28, 2004 at 05:33:03PM -0700, Jake Khuon wrote: > BMS> > That patch worked perfectly. I had to do a little hand-patching = of one of > BMS> > the hunks that got rejected though. Any thoughts on if this wil= l get > BMS> > merged? Thanks. > BMS>=20 > BMS> Please send me these patches so I can look at them... >=20 > After applying the patch, I did a backdiff. This is against: >=20 > /src/sys/dev/ata/ata-all.c,v 1.233 2004/10/19 20:13:38 > *************** > *** 346,356 **** > --- 347,359 ---- > if (ch->state =3D=3D ATA_IDLE) { > ch->state =3D ATA_ACTIVE; > mtx_unlock(&ch->state_mtx); > + goto out; > break; > } > mtx_unlock(&ch->state_mtx); > tsleep(ch, PRIBIO, "atasusp", hz/10); > } > + out: =20 > ch->locking(ch, ATA_LF_UNLOCK); > return 0; > } That part cant be needed right ? As for the rest, it works around the problem that tsleep doesn't seem to = work on the resume path under APM. Now that is all nice and that, but=20 I'd like to get the real problem fixed: why doesn't tsleep work there ? --=20 -S=F8ren