From nobody Sat Nov 18 04:52:49 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SXLxP4w69z51m5J; Sat, 18 Nov 2023 04:52:57 +0000 (UTC) (envelope-from yuri@aetern.org) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4SXLxP2sQqz3F3b; Sat, 18 Nov 2023 04:52:57 +0000 (UTC) (envelope-from yuri@aetern.org) Authentication-Results: mx1.freebsd.org; none Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 247F73200786; Fri, 17 Nov 2023 23:52:56 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 17 Nov 2023 23:52:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aetern.org; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1700283175; x=1700369575; bh=IadZyhx+oEECbm5cD3Me6/XVlmwE3k354C2 7ZLSO3XY=; b=83eIVZ3xO/AFeANqGZrIR2omhM6QGA8LwvGN9i6iTC3LBtd+otC tDAFRNbdF+nh9rWW9scjLaUIAD3PdyZS286KuKAH99SrivCVV2F+6O20LXDkUiz7 +E0AsdfcUB35VLNv2XhRFJWS3emQldKESZLTFRWF+NKEixvZfVsqIX2qYR+b93sO jPHopoGH71AELsy9/2a/3CFzv1/hcfKlC6Bmqzu8/tI7dqHVhgwYV3K10mLEuY3u im5VKhe3p8fjASkfuRqx+VzwUpI6xhDDLrcJ6w++dw1If73jJqr6+1q9XhRSGC9q zOJLGDmMfTykjTYTHuajtW11S83zh0/6APw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1700283175; x= 1700369575; bh=IadZyhx+oEECbm5cD3Me6/XVlmwE3k354C27ZLSO3XY=; b=L MkbPGFR9IVGuUlWAElNweDqULPAwwdx4Zoy5CPHz0iY4Eb/htjlXIGQvN5XpfYRh Wzt6YLDUrXi9OEvG+s6GEZu65L3MDgy2nRRwNVJcKYTArtguZstXsl1aXs7APnn3 TSyKAS60WzaAubKa3Ey/1/W6cvOitAaZBvtKlfpH7fhb6PRtm7qx6axasNuyjuB/ UGIlj+Tn6oHmOhQMdPa4FpCoG4B4uc1XPfHYCFpNTy6RewWZ9zO+cD0Hhnhc7bPs RAx/v9gjRtu4+nWWoGFgsz8Jn2zRx2hlh49DLPKMu+W4KEu7GuKFcGJTEXpbOihZ Ra/7gWAHegwUH0lhpItzA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeguddgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje ertddtvdejnecuhfhrohhmpegjuhhrihcuoeihuhhrihesrggvthgvrhhnrdhorhhgqeen ucggtffrrghtthgvrhhnpeevkefhfeffgefhheelgeelhfekgedtlefgvdelvdeufeehhf etjeeikeefgfffleenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeihuhhrihesrggvthgvrh hnrdhorhhg X-ME-Proxy: Feedback-ID: i0d79475b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Nov 2023 23:52:53 -0500 (EST) Message-ID: <71162369-66f6-4f08-9ba7-e87236151fee@aetern.org> Date: Sat, 18 Nov 2023 11:52:49 +0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 34a6ad848fbf - main - nvme: Don't use version to listen for events for ns and fw changes To: Warner Losh , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202311180432.3AI4W3YM029176@gitrepo.freebsd.org> Content-Language: en-US From: Yuri In-Reply-To: <202311180432.3AI4W3YM029176@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29838, ipnet:64.147.123.0/24, country:US] X-Rspamd-Queue-Id: 4SXLxP2sQqz3F3b Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=34a6ad848fbf471773a430a7e457bf49816e756e > > commit 34a6ad848fbf471773a430a7e457bf49816e756e > Author: Warner Losh > AuthorDate: 2023-11-18 04:24:00 +0000 > Commit: Warner Losh > CommitDate: 2023-11-18 04:25:57 +0000 > > nvme: Don't use version to listen for events for ns and fw changes > > Instead, use the attribtue bits from the identification data to > determine if we should listen to namespace changes and firmware > activation. Should have no functional change, though we may stop > listening for events that will never happen. > > Sponsored by: Netflix > --- > sys/dev/nvme/nvme_ctrlr.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c > index 5d72f707d3b1..836d13eaa16d 100644 > --- a/sys/dev/nvme/nvme_ctrlr.c > +++ b/sys/dev/nvme/nvme_ctrlr.c > @@ -826,8 +826,9 @@ nvme_ctrlr_configure_aer(struct nvme_controller *ctrlr) > NVME_CRIT_WARN_ST_READ_ONLY | > NVME_CRIT_WARN_ST_VOLATILE_MEMORY_BACKUP; > if (ctrlr->cdata.ver >= NVME_REV(1, 2)) It seems to be under version check still? Or am I misreading the commit message? > - ctrlr->async_event_config |= NVME_ASYNC_EVENT_NS_ATTRIBUTE | > - NVME_ASYNC_EVENT_FW_ACTIVATE; > + ctrlr->async_event_config |= > + ctrlr->cdata.oaes & (NVME_ASYNC_EVENT_NS_ATTRIBUTE | > + NVME_ASYNC_EVENT_FW_ACTIVATE); > > status.done = 0; > nvme_ctrlr_cmd_get_feature(ctrlr, NVME_FEAT_TEMPERATURE_THRESHOLD,