From owner-svn-src-all@FreeBSD.ORG Sat Mar 17 22:14:43 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E582B1065673; Sat, 17 Mar 2012 22:14:43 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from argol.doit.wisc.edu (argol.doit.wisc.edu [144.92.197.212]) by mx1.freebsd.org (Postfix) with ESMTP id B57A78FC12; Sat, 17 Mar 2012 22:14:43 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed; delsp=yes Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) id <0M1100300V4CQ100@smtpauth3.wiscmail.wisc.edu>; Sat, 17 Mar 2012 17:14:36 -0500 (CDT) Received: from [10.0.2.93] ([unknown] [76.210.64.28]) by smtpauth3.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) with ESMTPSA id <0M1100LDOV4BSO10@smtpauth3.wiscmail.wisc.edu>; Sat, 17 Mar 2012 17:14:36 -0500 (CDT) Date: Sat, 17 Mar 2012 17:14:34 -0500 From: Nathan Whitehorn In-reply-to: <201203172204.q2HM4xBH088986@svn.freebsd.org> To: Alan Cox Message-id: X-Mailer: Apple Mail (2.936) X-Spam-Report: AuthenticatedSender=yes, SenderIP=76.210.64.28 X-Spam-PmxInfo: Server=avs-16, Version=5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.3.17.220315, SenderIP=76.210.64.28 References: <201203172204.q2HM4xBH088986@svn.freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233097 - head/sys/amd64/amd64 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2012 22:14:44 -0000 On Mar 17, 2012, at 5:04 PM, Alan Cox wrote: > Author: alc > Date: Sat Mar 17 22:04:58 2012 > New Revision: 233097 > URL: http://svn.freebsd.org/changeset/base/233097 > > Log: > With the changes over the past year to how accesses to the page's > dirty > field are synchronized, there is no need for pmap_protect() to > acquire > the page queues lock unless it is going to access the pv lists. > > Reviewed by: kib Under what circumstances does the page queue lock actually have to be held? It looks like from this that I can remove the page queue lock from the PPC/AIM pmap_protect() completely, but I don't have a good sense of it. -Nathan