From owner-svn-soc-all@FreeBSD.ORG  Thu Jul 18 15:53:53 2013
Return-Path: <owner-svn-soc-all@FreeBSD.ORG>
Delivered-To: svn-soc-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 17507569
 for <svn-soc-all@FreeBSD.org>; Thu, 18 Jul 2013 15:53:53 +0000 (UTC)
 (envelope-from mattbw@FreeBSD.org)
Received: from socsvn.freebsd.org (socsvn.freebsd.org
 [IPv6:2001:1900:2254:206a::50:2])
 by mx1.freebsd.org (Postfix) with ESMTP id 092347D9
 for <svn-soc-all@FreeBSD.org>; Thu, 18 Jul 2013 15:53:53 +0000 (UTC)
Received: from socsvn.freebsd.org ([127.0.1.124])
 by socsvn.freebsd.org (8.14.7/8.14.7) with ESMTP id r6IFrqbn055628
 for <svn-soc-all@FreeBSD.org>; Thu, 18 Jul 2013 15:53:52 GMT
 (envelope-from mattbw@FreeBSD.org)
Received: (from www@localhost)
 by socsvn.freebsd.org (8.14.7/8.14.6/Submit) id r6IFrq6Z055626
 for svn-soc-all@FreeBSD.org; Thu, 18 Jul 2013 15:53:52 GMT
 (envelope-from mattbw@FreeBSD.org)
Date: Thu, 18 Jul 2013 15:53:52 GMT
Message-Id: <201307181553.r6IFrq6Z055626@socsvn.freebsd.org>
X-Authentication-Warning: socsvn.freebsd.org: www set sender to
 mattbw@FreeBSD.org using -f
From: mattbw@FreeBSD.org
To: svn-soc-all@FreeBSD.org
Subject: socsvn commit: r254917 - soc2013/mattbw/backend/actions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-soc-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the entire Summer of Code repository
 <svn-soc-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-soc-all>
List-Post: <mailto:svn-soc-all@freebsd.org>
List-Help: <mailto:svn-soc-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jul 2013 15:53:53 -0000

Author: mattbw
Date: Thu Jul 18 15:53:52 2013
New Revision: 254917
URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=254917

Log:
  emit (somewhat misleading) error for failed refresh

Modified:
  soc2013/mattbw/backend/actions/refresh_cache.c

Modified: soc2013/mattbw/backend/actions/refresh_cache.c
==============================================================================
--- soc2013/mattbw/backend/actions/refresh_cache.c	Thu Jul 18 14:06:01 2013	(r254916)
+++ soc2013/mattbw/backend/actions/refresh_cache.c	Thu Jul 18 15:53:52 2013	(r254917)
@@ -55,7 +55,7 @@
 #include "../actions.h"		/* refresh_cache_thread prototype */
 #include "../pkgutils.h"	/* pkgutils_... */
 #include "../query.h"		/* query_... */
-#include "../utils.h"		/* STATUS */
+#include "../utils.h"		/* STATUS, ERR */
 
 /*
  * The thread that performs a RefreshCache operation. Should be invoked
@@ -80,8 +80,12 @@
 		/* Intentionally silence already-up-to-date errors. */
 		if (err == EPKG_UPTODATE)
 			err = EPKG_OK;
-		else if (err != EPKG_OK)
+		else if (err != EPKG_OK) {
+			ERR(backend,
+			    PK_ERROR_ENUM_REPO_NOT_AVAILABLE,
+			    "could not update repo");
 			break;
+		}
 	}
 
 	pk_backend_finished(backend);