From owner-freebsd-current@FreeBSD.ORG Fri Jan 16 02:09:13 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12E4016A4CE; Fri, 16 Jan 2004 02:09:13 -0800 (PST) Received: from cheer.mahoroba.org (flets20-024.kamome.or.jp [218.45.20.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id B39F743D54; Fri, 16 Jan 2004 02:09:10 -0800 (PST) (envelope-from ume@FreeBSD.org) Received: from plum.ssr.bisd.hitachi.co.jp (ume@plum.v6.spacecom.netspace.or.jp [IPv6:2001:200:165:100:2a0:c9ff:fe8c:143d]) (user=ume mech=CRAM-MD5 bits=0)i0GA94mw087643; Fri, 16 Jan 2004 19:09:04 +0900 (JST) (envelope-from ume@FreeBSD.org) Date: Fri, 16 Jan 2004 19:09:03 +0900 Message-ID: From: Hajimu UMEMOTO To: "Bjoern A. Zeeb" In-Reply-To: References: <20040115041435.7B739A6@coconut.itojun.org> User-Agent: xcite1.38> Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386--freebsd) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) X-Operating-System: FreeBSD 4.8-RELEASE-p13 MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.61 X-Spam-Checker-Version: SpamAssassin 2.61 (1.212.2.1-2003-12-09-exp) on cheer.mahoroba.org cc: current@freebsd.org cc: core@kame.net cc: Hajimu UMEMOTO cc: "Bjoern A. Zeeb" cc: Jun-ichiro itojun Hagino Subject: Re: [PATCH] IPSec fixes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jan 2004 10:09:13 -0000 Hi, >>>>> On Fri, 16 Jan 2004 09:31:25 +0000 (UTC) >>>>> bzeeb-lists@lists.zabbadoz.net ("Bjoern A. Zeeb") said: bzeeb-lists> I never applied it as going through the code showed that it will not bzeeb-lists> do the right thing(TM). See older mail. You wrote that the check is entirely useless. However, the patch actually changed the behavior and fixed the problem on my box. Without the patch, I could reproduce a panic easily by setkey. So, I wish to hear an actuall result on your box. bzeeb-lists> ahh - this isn't exactly the diff itojun offered. bzeeb-lists> the newsp->refcnt++; is missing. Is it also missing in your kernel ? Yes. Since you pointed that this is wrong, and itojun agreed with it. So, I nuked this line. bzeeb-lists> PS: do you have other patches in your local tree that are not yet bzeeb-lists> in HEAD ? I got another patch from you once in Nov or Dec but I think bzeeb-lists> it was renaming functions and passing pcb instead of so only (removing bzeeb-lists> some unnecessary function calls) [more like FATS_IPSEC]. I have a more bzeeb-lists> improved version of this in my private patchset but currently bzeeb-lists> suspended while debugging. No, I'm not applying any other patches. Originally, it was jlemon's work. It was withdrawed during KAME merge. When this issue is fixed, I'll rework about this. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/