Date: Mon, 10 Dec 2012 14:47:09 -0500 From: John Baldwin <jhb@freebsd.org> To: Carl Delsey <carl.r.delsey@intel.com> Cc: svn-src-head@freebsd.org, Jim Harris <jimharris@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r243960 - in head/sys: amd64/include i386/include x86/include Message-ID: <201212101447.09407.jhb@freebsd.org> In-Reply-To: <50C2832C.9080501@intel.com> References: <201212062233.qB6MXWpP046167@svn.freebsd.org> <201212071208.28158.jhb@freebsd.org> <50C2832C.9080501@intel.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, December 07, 2012 7:00:44 pm Carl Delsey wrote: > On 12/07/12 10:08, John Baldwin wrote: > > On Thursday, December 06, 2012 5:33:32 pm Jim Harris wrote: > >> Author: jimharris > >> Date: Thu Dec 6 22:33:31 2012 > >> New Revision: 243960 > >> URL: http://svnweb.freebsd.org/changeset/base/243960 > >> > >> Log: > >> Add amd64 implementations for 8-byte bus_space routines. > >> > >> Submitted by: Carl Delsey <carl.r.delsey@intel.com> > >> Discussed with: jhb, rwatson > >> Reviewed by: jimharris > >> MFC after: 1 week > >> > >> Modified: > >> head/sys/amd64/include/bus.h > >> head/sys/i386/include/bus.h > >> head/sys/x86/include/bus.h > > Do we still want the link errors on i386? Do you get a compile error now? > > > You get a compile error now, since the function prototypes don't exist > for i386. That was the case in the old code too. The comments about > forcing a link error were incorrect or obsolete. Ok, sounds good to me, thanks! -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212101447.09407.jhb>