From owner-svn-src-head@FreeBSD.ORG  Mon Dec 10 21:41:40 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 21212790;
 Mon, 10 Dec 2012 21:41:40 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id E244B8FC0C;
 Mon, 10 Dec 2012 21:41:39 +0000 (UTC)
Received: from pakbsde14.localnet (unknown [38.105.238.108])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 44A8FB94A;
 Mon, 10 Dec 2012 16:41:39 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Carl Delsey <carl.r.delsey@intel.com>
Subject: Re: svn commit: r243960 - in head/sys: amd64/include i386/include
 x86/include
Date: Mon, 10 Dec 2012 14:47:09 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; )
References: <201212062233.qB6MXWpP046167@svn.freebsd.org>
 <201212071208.28158.jhb@freebsd.org> <50C2832C.9080501@intel.com>
In-Reply-To: <50C2832C.9080501@intel.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201212101447.09407.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Mon, 10 Dec 2012 16:41:39 -0500 (EST)
Cc: svn-src-head@freebsd.org, Jim Harris <jimharris@freebsd.org>,
 svn-src-all@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Dec 2012 21:41:40 -0000

On Friday, December 07, 2012 7:00:44 pm Carl Delsey wrote:
> On 12/07/12 10:08, John Baldwin wrote:
> > On Thursday, December 06, 2012 5:33:32 pm Jim Harris wrote:
> >> Author: jimharris
> >> Date: Thu Dec  6 22:33:31 2012
> >> New Revision: 243960
> >> URL: http://svnweb.freebsd.org/changeset/base/243960
> >>
> >> Log:
> >>    Add amd64 implementations for 8-byte bus_space routines.
> >>    
> >>    Submitted by:	Carl Delsey <carl.r.delsey@intel.com>
> >>    Discussed with:	jhb, rwatson
> >>    Reviewed by:	jimharris
> >>    MFC after:	1 week
> >>
> >> Modified:
> >>    head/sys/amd64/include/bus.h
> >>    head/sys/i386/include/bus.h
> >>    head/sys/x86/include/bus.h
> > Do we still want the link errors on i386?  Do you get a compile error now?
> >
> You get a compile error now, since the function prototypes don't exist 
> for i386. That was the case in the old code too. The comments about 
> forcing a link error were incorrect or obsolete.

Ok, sounds good to me, thanks!

-- 
John Baldwin