From owner-svn-src-head@freebsd.org Sat Dec 31 21:53:28 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3FB9C991DB for ; Sat, 31 Dec 2016 21:53:28 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm18-vm4.bullet.mail.ne1.yahoo.com (nm18-vm4.bullet.mail.ne1.yahoo.com [98.138.91.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A05BD1A5A for ; Sat, 31 Dec 2016 21:53:28 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1483220854; bh=qXwSUOenAlZFXP6FC3OdnBIxW7YqJun8RvJxGNR+sVw=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=Vku45nlNjTK7NRJE+d483mQMPHekd/4ECpA/V9qdswWTH16Jd04AjLlsRUPZWOJDQUNotD3654qKJyto1dfB1w7T3tbsUqG2hjLsn+OnY9K9g+uBziQVFq3zKwO6Tf3zkTrfh5frjbeQBf/3huWr4EFtasIfVcXRxpglWFhBqZTeRIwxE1QIx0CHPPkeRXetUyN1XqMsAuxECovNkfi3fFiL4rovnE6KLv3lo60/N+4YF44pNoK5TTO8saAyCi0G7nxBOrdraYU0zF5eDUMYo4G69XuUz8EoRJ/x+ehYCq32E9ZpyVH06uvukVi91ZtCJwAl9iMEEWn+B9amGEjFJQ== Received: from [98.138.101.132] by nm18.bullet.mail.ne1.yahoo.com with NNFMP; 31 Dec 2016 21:47:34 -0000 Received: from [98.138.226.60] by tm20.bullet.mail.ne1.yahoo.com with NNFMP; 31 Dec 2016 21:47:34 -0000 Received: from [127.0.0.1] by smtp211.mail.ne1.yahoo.com with NNFMP; 31 Dec 2016 21:47:34 -0000 X-Yahoo-Newman-Id: 781880.51902.bm@smtp211.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: V5qqPpgVM1ldGjN9zesSHKC.eeFKehDvS9kI7EwbId5jnpN 8BwfBGxdJ3gcTmeTGjtI9ennozgGvmhZrKKvxq52kG7kmFhhHN5UJHd_bUCN mB69gmB6wXFnKz82ZrangKWHiCyz1fM93N8PplGn2h2OwaWhQY.R9nozKtOi r41h3MVT9enrpe.TW0gZWV5Yj0rtk2V6Ni37qI7GlToAdtBcztuZLzjih27G _N2LHcrCg2Ud4OljWWiMCPbfgyOyRBg78k3FVSLDocWa0Nax12REMd_YXXay h7BV7cXFl13oo.AXw7B4_x4LwBmONChWJ0fV1TvO0fytyvh.Ts5tpOxE_dgv xr5ueoJEfmAwZUtOsUN0DYXt4GxxsANvE0b6PVZ5995Hg_MyzSahvtKBW9FD fnruSge_d6HjIUlQkJ4yHCx4EbOLu8bcx_vsTAPtSSkk3_xQXTuaVDkPOOCH Fm6bD1b1XidP3sNwInNnlLPMyAzUP3XVAaFpMfYvTMI1a6f7Lkg5RoXuk38S xKnGoQ1WgRSx7MLgNE2wTPruJDPSYfN50XzsercibajE5Fgc- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r310984 - head/lib/libc/net To: Ngie Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201612312100.uBVL09RR092355@repo.freebsd.org> From: Pedro Giffuni Message-ID: <7914bb49-6bef-6bbd-5574-ceb29f318c01@FreeBSD.org> Date: Sat, 31 Dec 2016 16:49:10 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <201612312100.uBVL09RR092355@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Dec 2016 21:53:28 -0000 On 12/31/16 16:00, Ngie Cooper wrote: > Author: ngie > Date: Sat Dec 31 21:00:08 2016 > New Revision: 310984 > URL: https://svnweb.freebsd.org/changeset/base/310984 > > Log: > Use calloc instead of malloc + memset(.., 0, ..) > > MFC after: 1 week > > Modified: > head/lib/libc/net/getaddrinfo.c > > Modified: head/lib/libc/net/getaddrinfo.c > ============================================================================== > --- head/lib/libc/net/getaddrinfo.c Sat Dec 31 19:59:31 2016 (r310983) > +++ head/lib/libc/net/getaddrinfo.c Sat Dec 31 21:00:08 2016 (r310984) > @@ -691,9 +691,8 @@ reorder(struct addrinfo *sentinel) > return(n); > > /* allocate a temporary array for sort and initialization of it. */ > - if ((aio = malloc(sizeof(*aio) * n)) == NULL) > + if ((aio = calloc(1, sizeof(*aio) * n)) == NULL) > return(n); /* give up reordering */ This should be calloc(n, sizeof(*aio))) FWIW, the other cases are not very useful. Generally, replacing any malloc(x) with a calloc(1, x) doesn't bring any advantage as it won't catch any overflow. Pedro.