From owner-cvs-all Wed Oct 23 21:12: 5 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BD4937B401; Wed, 23 Oct 2002 21:12:04 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E07743E3B; Wed, 23 Oct 2002 21:12:03 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id OAA32182; Thu, 24 Oct 2002 14:11:55 +1000 Date: Thu, 24 Oct 2002 14:22:59 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/lib/libdisk Makefile chunk.c write_alpha_disk.c write_i386_disk.c write_pc98_disk.c In-Reply-To: <200210232002.g9NK2XB8026621@repoman.freebsd.org> Message-ID: <20021024141049.G25683-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 23 Oct 2002, Poul-Henning Kamp wrote: > phk 2002/10/23 13:02:33 PDT > > Modified files: > lib/libdisk Makefile chunk.c write_alpha_disk.c > write_i386_disk.c write_pc98_disk.c > Log: > Remove unnecessary ioctls tickling kernel side to realize that we fiddled > with the disk. GEOM will automatically retaste when we closet he filedesc. > > Revision Changes Path > 1.34 +1 -0 src/lib/libdisk/Makefile > 1.35 +1 -1 src/lib/libdisk/chunk.c > 1.2 +1 -11 src/lib/libdisk/write_alpha_disk.c > 1.2 +0 -11 src/lib/libdisk/write_i386_disk.c > 1.2 +0 -10 src/lib/libdisk/write_pc98_disk.c Breakage of the non-GEOM case continues. The slice layer always reloads the slice and partition tables on last close (actually on the next open). But a DIOCSYNCSLICEINFO ioctl is required to reload the when the close is not the last. One of the main gotchas in using the standalone fdisk(8) is that it doesn't do the DIOCSLICEINFO. This change makes sysinstall's fdisk bug-for-bug compatible with the standalone fdisk. This change also attempts to break the non-GEOM case more fundamentally by removing DIOCWLABEL ioctls. This should make writes over old labels fail. However, write protection of labels doesn't actually work if the writes are made to the whole disk device. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message