From owner-p4-projects@FreeBSD.ORG  Thu Aug 21 19:27:50 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 00E10106567F; Thu, 21 Aug 2008 19:27:50 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B8D49106567C
	for <perforce@FreeBSD.org>; Thu, 21 Aug 2008 19:27:49 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id A4F3F8FC25
	for <perforce@FreeBSD.org>; Thu, 21 Aug 2008 19:27:49 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7LJRnuD093305
	for <perforce@FreeBSD.org>; Thu, 21 Aug 2008 19:27:49 GMT
	(envelope-from ed@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7LJRn1f093303
	for perforce@freebsd.org; Thu, 21 Aug 2008 19:27:49 GMT
	(envelope-from ed@FreeBSD.org)
Date: Thu, 21 Aug 2008 19:27:49 GMT
Message-Id: <200808211927.m7LJRn1f093303@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	ed@FreeBSD.org using -f
From: Ed Schouten <ed@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 148033 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Aug 2008 19:27:50 -0000

http://perforce.freebsd.org/chv.cgi?CH=148033

Change 148033 by ed@ed_flippo on 2008/08/21 19:27:10

	Small style(9) nits.

Affected files ...

.. //depot/projects/mpsafetty/sys/kern/tty.c#28 edit

Differences ...

==== //depot/projects/mpsafetty/sys/kern/tty.c#28 (text+ko) ====

@@ -1681,19 +1681,18 @@
 	struct cdevsw *cdp;
 	int error;
 
-	/* Validate the file descriptor */
+	/* Validate the file descriptor. */
 	if (fget(td, fd, &fp) != 0)
 		return (EINVAL);
 	
-	/* Make sure the vnode is bound to a character device */
+	/* Make sure the vnode is bound to a character device. */
 	error = EINVAL;
 	if (fp->f_type != DTYPE_VNODE || fp->f_vnode->v_type != VCHR ||
-	    fp->f_vnode->v_rdev == NULL) {
+	    fp->f_vnode->v_rdev == NULL)
 		goto done1;
-	}
 	dev = fp->f_vnode->v_rdev;
 
-	/* Make sure it is a TTY */
+	/* Make sure it is a TTY. */
 	cdp = dev_refthread(dev);
 	if (cdp == NULL)
 		goto done1;
@@ -1701,7 +1700,7 @@
 		goto done2;
 	tp = dev->si_drv1;
 
-	/* Try to attach the hook to the TTY */
+	/* Try to attach the hook to the TTY. */
 	error = EBUSY;
 	tty_lock(tp);
 	MPASS((tp->t_hook == NULL) == ((tp->t_flags & TF_HOOK) == 0));
@@ -1727,11 +1726,11 @@
 	tty_lock_assert(tp, MA_OWNED);
 	MPASS(tp->t_flags & TF_HOOK);
 
-	/* Disconnect the hook */
+	/* Disconnect the hook. */
 	tp->t_flags &= ~TF_HOOK;
 	tp->t_hook = NULL;
 
-	/* Maybe deallocate the TTY as well */
+	/* Maybe deallocate the TTY as well. */
 	tty_rel_free(tp);
 }