From owner-freebsd-ports@FreeBSD.ORG Wed Aug 25 18:11:54 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 360A3106566C for ; Wed, 25 Aug 2010 18:11:54 +0000 (UTC) (envelope-from demelier.david@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id BDBB58FC16 for ; Wed, 25 Aug 2010 18:11:53 +0000 (UTC) Received: by wyb33 with SMTP id 33so1121099wyb.13 for ; Wed, 25 Aug 2010 11:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=O8+pw27u1oBwumLZDuN5qY4UKRonYlSmafiahEfY9ek=; b=PAMOG8IWzSBKfOvC77nrV3T8lzKvx2VNZzp9CURMx3wbEaGnFv5zuYwunN2SajSx6t s5F59NK6oCs4GdHWE4Vf1ywBS3UC5585dxUP5R/Gfm3kagxSjUdYQQyl5t9TMHOavbMy 0azmYItHxEtcLUmmiMRcgF9TDJBS8ldBaIdjo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=GwL9fTDRWECwfs8yRAsP+UBHM/oTD+AOS1O9HVWRwESrZeq0cIb7CMD6Chr/o2jXXC JSWibkm5InB+sjAATO1ksTzKLSc9iaO4wtRpq2n9VWEQlURm6kjpTG/ScTJfQHruvZJM Nv1nJ4kyhAzWARDKuYBpekn0y6KwlzpVtUruk= Received: by 10.227.133.14 with SMTP id d14mr1393220wbt.44.1282759911196; Wed, 25 Aug 2010 11:11:51 -0700 (PDT) Received: from Melon.malikania.fr (34.21.102-84.rev.gaoland.net [84.102.21.34]) by mx.google.com with ESMTPS id e31sm1405943wbe.23.2010.08.25.11.11.50 (version=SSLv3 cipher=RC4-MD5); Wed, 25 Aug 2010 11:11:50 -0700 (PDT) Message-ID: <4C755CBD.9070801@gmail.com> Date: Wed, 25 Aug 2010 20:11:09 +0200 From: David Demelier User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.8) Gecko/20100818 Thunderbird/3.1.2 MIME-Version: 1.0 To: freebsd-ports@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Legal music and sound issues with games/viruskiller X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2010 18:11:54 -0000 Hi, We rewrote the games/viruskiller with one option, MUSIC. The musics and sounds have legal issues and that is specified here : http://www.happypenguin.org/forums/viewtopic.php?t=4725 Because I wanted to write this port, I made this option to interact with the user. He needs to enable the option to use the sounds and musics. I also said in the comment options that the files are non-free, then the user is completely warned. Do you agree with this Makefile now ? --- Makefile.orig 2010-08-25 19:20:40.000000000 +0200 +++ Makefile 2010-08-25 20:06:48.000000000 +0200 @@ -20,15 +20,26 @@ USE_SDL= mixer image ttf net USE_GMAKE= yes +NO_CDROM= yes + INSTALLS_ICONS= yes WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} MAKEFILE= makefile +OPTIONS= MUSIC "Enable musics (non-free)" Off + +.include + +.if !defined(WITH_MUSIC) +SUB_FILES= pkg-message +.endif + post-patch: - # Remove non-free restricted files: - ${RM} -f ${WRKSRC}/music/* ${WRKSRC}/sound/* +.if !defined(WITH_MUSIC) + @${REINPLACE_CMD} -e "s|music||g;s|sound||g" ${WRKSRC}/makefile +.endif .if defined(NOPORTDOCS) @${REINPLACE_CMD} -e "s|^.*install.*DOCS.*||g" \ @@ -40,4 +51,9 @@ -e "s|^DATADIR.*|DATADIR=${DATADIR}/|g" \ -e "s|^DOCDIR.*|DOCDIR=${DOCSDIR}|g" ${WRKSRC}/makefile +post-install: +.if !defined(WITH_MUSIC) + @${CAT} ${PKGMESSAGE} +.endif + .include --- /dev/null 2010-08-25 20:08:43.000000000 +0200 +++ files/pkg-message.in 2010-08-25 20:05:20.000000000 +0200 @@ -0,0 +1,2 @@ +Because you disabled music you need to start viruskiller with the -noaudio flag, +otherwise it will segfaults. I think with this, we could keep the game in the ports/ tree. With kind regards.