From owner-freebsd-net@FreeBSD.ORG Tue May 18 18:07:44 2010 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B51A1065670; Tue, 18 May 2010 18:07:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1F04A8FC1A; Tue, 18 May 2010 18:07:44 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id CDAF146B8D; Tue, 18 May 2010 14:07:43 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 0FAC48A01F; Tue, 18 May 2010 14:07:43 -0400 (EDT) From: John Baldwin To: pyunyh@gmail.com Date: Tue, 18 May 2010 14:07:33 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201005181315.37609.jhb@freebsd.org> <20100518173032.GC5968@michelle.cdnetworks.com> In-Reply-To: <20100518173032.GC5968@michelle.cdnetworks.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005181407.33474.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 18 May 2010 14:07:43 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Navdeep Parhar , net@freebsd.org Subject: Re: Configuring flow control for network interfaces X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2010 18:07:44 -0000 On Tuesday 18 May 2010 1:30:32 pm Pyun YongHyeon wrote: > On Tue, May 18, 2010 at 01:15:37PM -0400, John Baldwin wrote: > > I think it would be useful if we could pick a device-independent interface for > > configuring flow control on network interfaces, perhaps as media options via > > ifconfig. I know that the msk(4) driver allows RX and TX flow control to be > > toggled via the link0 and link1 flags (the manpage for msk(4) needs updating > > on this topic I think). I have a hack for work to disable TX flow control on > > The hack used in e1000phy(4), brgphy(4) and ip1000phy(4) should be > removed. So this looks to actually be different (I was confused). Apparently the link[012] flags are separate from the flag[012] shared flags for ifmedia. It does look like the link0 use in these drivers could be replaced by proper use of IFM_ETH_MASTER media option flag instead. It seems that IFM_ETH_MASTER is missing from IFM_SUBTYPE_ETHERNET_OPTION_DESCRIPTIONS in ifmedia.h which would need to be fixed before ifconfig could get/set it. Once that change is in place I think these drivers could check that flag instead of the IFF_LINK0 to determine if they are the master. > > cxgb(4), but it doesn't use flow control currently. Is flow control ethernet- > > specific? If so, perhaps we could add two new flags for RX and TX flow > > control to the Ethernet-specific options in that case? Do folks have other > > ideas? > > > > AFAIK marius@ is working on it and may have latest patches. Ok. Does his patch use Ethernet-specific options or some other approach? -- John Baldwin