From nobody Wed Mar 26 01:28:51 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZMq1w1qXnz5s5vJ; Wed, 26 Mar 2025 01:28:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZMq1v2Y0Hz3r9P; Wed, 26 Mar 2025 01:28:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742952531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TTEgV6NdqNpmX91sO+7AyAtjEmaoT1YE1spdeNiDOkw=; b=k/Kq9JflH6PI2Y5+U2qVcy6tkKm+YJplDgYgCtPQXWstFyMgfOvUQgYBiN4ZRVPTWX24DZ eHk3GDwSxdUO7p6FQORo6KHEnMLj3vMHmBOOKEPAdQe0oKKXBO+wsxwS4u7pqh96TQjhOV CvAue+MO90jmcuBhhRtS6CY+ibd/KVwTW/k7Lps86+E0qQJeIC83lwRjyUgRaMYgxnGVKY hh8Uit7tHYxh/dVVyaaGPcLIb8W0zcT/iBwNkr/L4Gdqj+QgamzrurFoGhZsKMuvY3vNpN 7jvgRqWqRDu0gp++OIUEqEJTaRlEVYPs3zBibzCuwN7T92MRKwLeq/mFc6yCVw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1742952531; a=rsa-sha256; cv=none; b=r4uFc2aK8//5qQEPVuZgPig3gs6JVJjb1Nf9P25e2q6s/lRkemiRitAwb8fS2IswN0X8tX 3aU8HPi3x1grztPYalwU+B62MlSsxDQRmeT4uhZpI7Xe/U+KYW9gWIdPvSgsu37HLlNYL0 wJjjTf1JQ0lBoSEvhqSPzcN0TvzATNBNyiRxDsjXiMHqY3eyopDnCESQEhjekrdc5cuJZ0 JY3GUm4hG1WYGd/T2gb66bOO05eDHkSfiw9u35qRzr/SXWcagRGmcmYheEQfjt43lNUnoO 2y/EzXW6B9TBKlc1IN5dij1A7WgIvRUafzP+5MdFa2dWAF7Yz4PHGzZRp2rtyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742952531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TTEgV6NdqNpmX91sO+7AyAtjEmaoT1YE1spdeNiDOkw=; b=jdeWyD0Q5CW2Pc2gjO9ZamtqQredbz+BleAUThWGaOz1tm4UZbA/NOzV42xlfvZnOAO+4z aApAlrbQkNuwUcBtD22LASZKgGIv3umFaqDROp38C9YgDzpJq8vrOcN62FBFr9u/u8kO3x asDOm1ZFVKyt+cwQSGPEz7ddI39aweGKslnv6MLaWX8dMbJYXnah9cMl8dzDKBeT1fVDrl 9fBV728L7VmKUNuw4aCvf6Ol+YWI1IJKDW91B9sjFOpAA+5wCCKLiAXfYDkyXpgXurhn0e 5R1eiWC1HPm/L6A0J6Py19Bu+EDg7MT0PQOsbrNmV9Nxh9kHEFibpoe4f/2JGg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZMq1v28PBz1544; Wed, 26 Mar 2025 01:28:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52Q1Spic046981; Wed, 26 Mar 2025 01:28:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52Q1Spnr046978; Wed, 26 Mar 2025 01:28:51 GMT (envelope-from git) Date: Wed, 26 Mar 2025 01:28:51 GMT Message-Id: <202503260128.52Q1Spnr046978@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: 1a8a24e34031 - stable/14 - acpi_iicbus: Shift slave address List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1a8a24e34031513e9b311f55c46b9294d7aec426 Auto-Submitted: auto-generated The branch stable/14 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=1a8a24e34031513e9b311f55c46b9294d7aec426 commit 1a8a24e34031513e9b311f55c46b9294d7aec426 Author: Ahmad Khalifa AuthorDate: 2024-04-19 22:43:19 +0000 Commit: Warner Losh CommitDate: 2025-03-26 01:28:37 +0000 acpi_iicbus: Shift slave address The address is expected to need shifting. see https://uefi.org/specs/ACPI/6.5/13_System_Mgmt_Bus_Interface_Specification.html#smbus-slave-addresses Reviewed by: imp, markj, Elliott Mitchell Pull Request: https://github.com/freebsd/freebsd-src/pull/1125 (cherry picked from commit 67677a654aa7456f18077ccbaa9c40f39a36d21a) --- sys/dev/iicbus/acpi_iicbus.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/dev/iicbus/acpi_iicbus.c b/sys/dev/iicbus/acpi_iicbus.c index c585f241fece..53171a72d995 100644 --- a/sys/dev/iicbus/acpi_iicbus.c +++ b/sys/dev/iicbus/acpi_iicbus.c @@ -255,6 +255,9 @@ acpi_iicbus_space_handler(UINT32 Function, ACPI_PHYSICAL_ADDRESS Address, sc = __containerof(info, struct acpi_iicbus_softc, space_handler_info); dev = sc->super_sc.dev; + /* the address is expected to need shifting */ + sb->SlaveAddress <<= 1; + switch (Function) { case AML_FIELD_ATTRIO(AML_FIELD_ATTRIB_SEND_RECEIVE, ACPI_READ): val = acpi_iicbus_recvb(dev, sb->SlaveAddress, gsb->data);