From owner-cvs-all@FreeBSD.ORG  Fri Oct  6 14:16:28 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 52E9816A415;
	Fri,  6 Oct 2006 14:16:28 +0000 (UTC) (envelope-from bde@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E3F2543DA7;
	Fri,  6 Oct 2006 14:16:21 +0000 (GMT) (envelope-from bde@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k96EGL4T015084;
	Fri, 6 Oct 2006 14:16:21 GMT (envelope-from bde@repoman.freebsd.org)
Received: (from bde@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k96EGLqY015083;
	Fri, 6 Oct 2006 14:16:21 GMT (envelope-from bde)
Message-Id: <200610061416.k96EGLqY015083@repoman.freebsd.org>
From: Bruce Evans <bde@FreeBSD.org>
Date: Fri, 6 Oct 2006 14:16:21 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: RELENG_4
Cc: 
Subject: cvs commit: src/sys/i386/isa cy.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Oct 2006 14:16:28 -0000

bde         2006-10-06 14:16:21 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_4)
    sys/i386/isa         cy.c 
  Log:
  Fail the probe instead of panicing if the memory address is 0.  The
  memory address can be 0 only with certain misconfigurations.  We don't
  try to detect misconfigurations of the kernel config file, but IIRC the
  panic was caused by a hardware misconfiguration like the following:
  - a cy PCI card physically present but with a hardware conflict
  - then the cy PCI probe is called first but fails due to the conflict
  - no cy ISA card present
  - the cy ISA probe is called.  Normally this uses the nonzero memory
    address in the config file and just fails when there is no cy ISA
    card present, but when there is a cy PCI card present, the ISA memory
    resource is apparently lost.  The (non-)presence of the cy ISA card
    probably makes no difference here.
  
  Revision  Changes    Path
  1.97.2.3  +3 -1      src/sys/i386/isa/cy.c