From owner-svn-ports-head@freebsd.org Tue Mar 16 19:59:39 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F2AD956B54E; Tue, 16 Mar 2021 19:59:39 +0000 (UTC) (envelope-from adridg@freebsd.org) Received: from lb1-smtp-cloud8.xs4all.net (lb1-smtp-cloud8.xs4all.net [194.109.24.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.xs4all.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F0PJV5s99z3LJ5; Tue, 16 Mar 2021 19:59:38 +0000 (UTC) (envelope-from adridg@freebsd.org) Received: from cust-d4a83f22 ([IPv6:fc0c:c11d:cecc:f58a:eaa1:c0:9d8f:c143]) by smtp-cloud8.xs4all.net with ESMTPA id MFqolJB7zjVXQMFqql6NUy; Tue, 16 Mar 2021 20:59:36 +0100 From: Adriaan de Groot To: Mathieu Arnold , Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files Date: Tue, 16 Mar 2021 20:59:29 +0100 Message-ID: <1829118.vR5SVPPSqJ@beastie.bionicmutton.org> Organization: FreeBSD In-Reply-To: <20210316021909.GB21936@FreeBSD.org> References: <202102242045.11OKjEpT075754@repo.freebsd.org> <20210225093513.GA59@FreeBSD.org> <20210316021909.GB21936@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart22486965.gYbqZ1YImA"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-CMAE-Envelope: MS4xfECozpBlzgJ5GFd3FiG7PCNxxwx5FdeYc3e5uid6vypzQb4h2Kf54jbox30Bif62sJi2fMkuHX5e53eSHrWz33vwGbygSJiJB2hGSlJp19ZkQ4WLY5z6 PcG/loZCEZT8prc/uD5s0ouezAt0dMTPQMIjmnvWfitsJmRYv8mk+8z8R82RyJ9WqzsDvsmlFKJdAPEC5sLzjGOPypSVPDY49idqKGBGkW//RbjtSLYfp/h1 kIBdUO3S4hDKbpi0XpkPh50lx+bkOcieKqZHqhwZ0gHVMsaOhdpqvDGHYrPuZ/CiZ1leEt1z2vw0orYUQByEbKfoa///air10dFRR1t6XPJtCEpKbutJASEm R5/1iYZRm3xZzN5Pm2o3z23TimHdbOVfFronAcYEH4OH577diTc= X-Rspamd-Queue-Id: 4F0PJV5s99z3LJ5 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:3265, ipnet:194.109.0.0/16, country:NL]; local_wl_from(0.00)[freebsd.org] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 19:59:40 -0000 --nextPart22486965.gYbqZ1YImA Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Adriaan de Groot To: Mathieu Arnold , Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files Date: Tue, 16 Mar 2021 20:59:29 +0100 Message-ID: <1829118.vR5SVPPSqJ@beastie.bionicmutton.org> Organization: FreeBSD In-Reply-To: <20210316021909.GB21936@FreeBSD.org> References: <202102242045.11OKjEpT075754@repo.freebsd.org> <20210225093513.GA59@FreeBSD.org> <20210316021909.GB21936@FreeBSD.org> On Tuesday, 16 March 2021 03:19:09 CET Alexey Dokuchaev wrote: > On Thu, Feb 25, 2021 at 09:35:13AM +0000, Alexey Dokuchaev wrote: > > On Thu, Feb 25, 2021 at 10:18:04AM +0100, Mathieu Arnold wrote: > > > On Wed, Feb 24, 2021 at 08:45:14PM +0000, Adriaan de Groot wrote: > > > > - @${REINPLACE_CMD} 's/\t//g' ${PKGINSTALL} ${PKGDEINSTALL} > > > > + # Drop all leading spaces in the script, to minify > > > > + @${REINPLACE_CMD} 's/^ *//' ${PKGINSTALL} ${PKGDEINSTALL} > > > > > > [[:space:]] works with all versions. > > > > Yes please. Not just it's more robust, it also expresses the intention > > better, as we probably want to trim *any* unnecessary whitespace, not > > some particular character. > > So, anything prevents us from going the [[:blank:]] way? So which is it, [[:space:]] or [[:blank:]] ? I don't have much reason to prod at this right now. [ade] (a character class accepting a, d or e, obvs) --nextPart22486965.gYbqZ1YImA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEhrjttu2OP5apuuy1z93JbxKxkVwFAmBRDiEACgkQz93JbxKx kVyBpQv/dAFbVw4M0rsXkj+tPxCxwBedIcDfdlZiqQ/9A1tEzd9d+AZuPhrCHl7A zPZaUrYSTjKwzFcw8bepEs9IB1oUgudw4zn28dqJH04MZQzvVaEtU4yMkHxymxnc w3xCbKHpwhEjm1WVrt/JsMhF46k74YrVkl2U7Mg+XRYpc3cuIXzpnltc1mHDd3h6 8+jDBltCI8siGBbsnHAVyCDhecl4/ZW/RtYSrnyirBVtjxpR4AH/igJzQva/ffVf QWAcPMnR6QDZlSezDO9BowuqUR/0vMU3KWh9NUoMDmKGufsyAmMNcBUa2L56Cr0k SOcDjR7Dm6Deql5jDy1WhQwSU7PAz4aoKOe9BqJjLPqw6reysrZJxPzjrVJj0+xe LTkUiuE46pwB7YHPc1f6j8l2tWxoQLDacXpi/qqwG47rAhM+04n3mb+61jY+ZPGj d3UksoFoxFIrPJ10u/VR7PqXu1511BwY5Vb+Abof10m4hrtHmSm7IT0q3t/pAUBJ +SLtzokX =tEqC -----END PGP SIGNATURE----- --nextPart22486965.gYbqZ1YImA--