From owner-svn-src-all@freebsd.org  Fri May 15 19:24:52 2020
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id A3C522FE464;
 Fri, 15 May 2020 19:24:52 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 49Nyz82qgTz4Kc3;
 Fri, 15 May 2020 19:24:52 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1])
 by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 04FJOoKR087850;
 Fri, 15 May 2020 12:24:50 -0700 (PDT)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: (from freebsd@localhost)
 by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 04FJOoQM087849;
 Fri, 15 May 2020 12:24:50 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <202005151924.04FJOoQM087849@gndrsh.dnsmgr.net>
Subject: Re: svn commit: r361066 - head/usr.sbin/jail
In-Reply-To: <0c6939cc-7f8a-d2fd-9da1-63eb641815e3@FreeBSD.org>
To: Ryan Moeller <freqlabs@freebsd.org>
Date: Fri, 15 May 2020 12:24:50 -0700 (PDT)
CC: Mateusz Piotrowski <0mp@freebsd.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 49Nyz82qgTz4Kc3
X-Spamd-Bar: -----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-5.97 / 15.00];
 NEURAL_HAM_MEDIUM(-0.97)[-0.969,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 May 2020 19:24:52 -0000

> On 5/15/20 6:18 AM, Mateusz Piotrowski wrote:
> 
> > On 5/15/20 1:38 AM, Ryan Moeller wrote:
> >> Author: freqlabs
> >> Date: Thu May 14 23:38:11 2020
> >> New Revision: 361066
> >> URL: https://svnweb.freebsd.org/changeset/base/361066
> >>
> >> Log:
> >>    jail: Add exec.prepare and exec.release command hooks
> >>    
> >>    This change introduces new jail command hooks that run before and after any
> >>    other actions.
> > Should it go into RELNOTES?
> I'm not sure what all the criteria are for relnotes.
> The committer's guide makes it seem like relnotes is for breaking 
> changes, which this is not.

Please could you point at which specific language in the commiters
guide makes you believe that the RELNOTES are for breaking changes?

RELNOTES should be for all changes that have user visible impact
of any type.

> -Ryan

-- 
Rod Grimes                                                 rgrimes@freebsd.org