From owner-p4-projects@FreeBSD.ORG  Sat Apr 22 22:16:52 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E0DD816A404; Sat, 22 Apr 2006 22:16:51 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A087616A416
	for <perforce@freebsd.org>; Sat, 22 Apr 2006 22:16:51 +0000 (UTC)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F300143D64
	for <perforce@freebsd.org>; Sat, 22 Apr 2006 22:16:48 +0000 (GMT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k3MMGm3a076051
	for <perforce@freebsd.org>; Sat, 22 Apr 2006 22:16:48 GMT
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k3MMGmrU076045
	for perforce@freebsd.org; Sat, 22 Apr 2006 22:16:48 GMT
	(envelope-from marcel@freebsd.org)
Date: Sat, 22 Apr 2006 22:16:48 GMT
Message-Id: <200604222216.k3MMGmrU076045@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 95896 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Apr 2006 22:16:52 -0000

http://perforce.freebsd.org/chv.cgi?CH=95896

Change 95896 by marcel@marcel_nfs on 2006/04/22 22:15:54

	Calculate the divisor before we set the DLAB bit. We can bail
	out, and would otherwise leave DLAB set. 

Affected files ...

.. //depot/projects/uart/dev/uart/uart_dev_ns8250.c#41 edit

Differences ...

==== //depot/projects/uart/dev/uart/uart_dev_ns8250.c#41 (text+ko) ====

@@ -194,11 +194,11 @@
 
 	/* Set baudrate. */
 	if (baudrate > 0) {
-		uart_setreg(bas, REG_LCR, lcr | LCR_DLAB);
-		uart_barrier(bas);
 		divisor = ns8250_divisor(bas->rclk, baudrate);
 		if (divisor == 0)
 			return (EINVAL);
+		uart_setreg(bas, REG_LCR, lcr | LCR_DLAB);
+		uart_barrier(bas);
 		uart_setdreg(bas, REG_DL, divisor);
 		uart_barrier(bas);
 	}