From owner-cvs-src@FreeBSD.ORG Mon Mar 6 23:24:09 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ECEED16A420; Mon, 6 Mar 2006 23:24:09 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CCAE43D69; Mon, 6 Mar 2006 23:24:09 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id k26NMIEi092360; Mon, 6 Mar 2006 16:22:22 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 06 Mar 2006 16:22:18 -0700 (MST) Message-Id: <20060306.162218.20524465.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <440B41DF.1010305@root.org> References: <20060305175247.149A616A44F@hub.freebsd.org> <440B41DF.1010305@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Mon, 06 Mar 2006 16:22:23 -0700 (MST) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, phk@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/usb umass.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2006 23:24:10 -0000 In message: <440B41DF.1010305@root.org> Nate Lawson writes: : Poul-Henning Kamp wrote: : > phk 2006-03-05 17:52:32 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/usb umass.c : > Log: : > When we get an unknown ATAPI comand, try it even if it is not listed, : > in all likelyhood just passing it through will work. : > : > Revision Changes Path : > 1.134 +4 -2 src/sys/dev/usb/umass.c : : Given that most umass devices can't even handle the commands required by : the spec (RBC), this seems dangerous. Still, might be worth trying in : HEAD just to see what commands it needs to support. It depends on the umass device. The thumb drives are universally stupid and fragile. This change is dangerous for them (although why one would send arbitrary commands to them I know not). There are a number of usb2 to PATA or SATA that this fix is the right thing to do, since for those it is required to get things like cdrecord to run w/o complaint. Warner