Date: Sat, 1 Dec 2007 14:07:50 -0800 (PST) From: Don Lewis <truckman@FreeBSD.org> To: brde@optusnet.com.au Cc: freebsd-fs@FreeBSD.org Subject: Re: File remove problem Message-ID: <200712012207.lB1M7oNg015468@gw.catspoiler.org> In-Reply-To: <20071201215706.B12006@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1 Dec, Bruce Evans wrote:
> On Sat, 1 Dec 2007, Kostik Belousov wrote:
>> +static int
>> +ffs_isronly(struct ufsmount *ump)
>> +{
>> + struct fs *fs = ump->um_fs;
>> +
>> + return (fs->fs_ronly);
>> +}
>> +
>
> Could be ump->um_fs->fs_ronly.
That's the change that I would have made. A #include for <ufs/ffs/fs.h>
would have to be added, which some might argue would be a layering
violation. I'd prefer to avoid the extra indirection.
> Anyway, doesn't the vn_start_write() in ffs_mount() wait for all writers
> like the rm process to complete?
vn_start_write() is used to block writes during certain stages of
snapshot creation.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712012207.lB1M7oNg015468>