From owner-cvs-all@FreeBSD.ORG Fri Dec 14 01:48:07 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91A2816A46B for ; Fri, 14 Dec 2007 01:48:07 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.181]) by mx1.freebsd.org (Postfix) with ESMTP id 1915D13C4FD for ; Fri, 14 Dec 2007 01:48:06 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so1489729waf.3 for ; Thu, 13 Dec 2007 17:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=cc2PQbMO4KDJpjQTlf3U0PqOf1CSr9EgFJIVO0pkyVs=; b=C8mdUTklBIHn6I+oz2nwTc30Fu0nZT9u9qZqILc9ailV5qj2n7ApvOa4E3w9G37YYPKsJSfxpLJV93ALTJGTHq54CogYpsykJLatdO97R2H/VspBnljCeCOobAH/siMACB57PO7Qwr+3XdOprQenPDzZVSSTmtLRlkVhEKt0B3w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=xd5KQ8ZFZ8iXx+7kx5CNSFI3AvgZ/6eRnd/c2GDGws1NQpf3XGUxC0G90ujUCB/hQ4kZNN3MVkD0+P+C2owmOJPaO7vEeft+PAbBOcEbmP0dwiwiGbcmH6UmQ4RNuaw1PmO3v5B+0nTBr9RKTtilVPM1Eum1RR0/2G8I9SmKTm4= Received: by 10.114.92.2 with SMTP id p2mr66011wab.90.1197596886433; Thu, 13 Dec 2007 17:48:06 -0800 (PST) Received: by 10.114.255.11 with HTTP; Thu, 13 Dec 2007 17:48:06 -0800 (PST) Message-ID: Date: Thu, 13 Dec 2007 17:48:06 -0800 From: "Kip Macy" To: "Robert Watson" In-Reply-To: <20071214011347.M86532@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200712122021.lBCKLdvt045540@repoman.freebsd.org> <20071213223319.E81630@maildrop.int.zabbadoz.net> <4761BB7C.3010907@elischer.org> <4761CB3F.3030905@delphij.net> <4761CDBA.9010906@samsco.org> <20071214005643.R86532@fledge.watson.org> <4761D791.5010003@samsco.org> <20071214011347.M86532@fledge.watson.org> Cc: Scott Long , src-committers@freebsd.org, d@delphij.net, Kip Macy , cvs-src@freebsd.org, cvs-all@freebsd.org, Julian Elischer , "Bjoern A. Zeeb" Subject: Re: cvs commit: src/sys/conf files src/sys/netinet tcp_ofld.c tcp_ofld.h tcp_var.h toedev.h src/sys/sys socket.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2007 01:48:07 -0000 On Dec 13, 2007 5:30 PM, Robert Watson wrote > > On Thu, 13 Dec 2007, Scott Long wrote: > > >> Let's not discourage that just yet. > > > > Yes, I would like to discourage disrespectful nit-picking of an important > > piece of work. > > I think you're reading too much into Bjoern's comments. > > >> I'd like to see all significant changes to TCP discussed on public mailing > >> lists well before they are committed -- at that point, someone saying > >> "actually, I'd name the files a bit differently" is a lot easier to deal > >> with than, say, immediately after they are committed. This needs to be > >> communally owned and maintained code, or in two years time we'll find > >> ourselves in the same position: architectural well-meant changes that are > >> mostly right, but with no review of the details leading to the inevitable > >> failures. > > > > A failure of what, exactly? Will the names that Kip chose lead to failures > > of TCP sessions? Please enlighten me here. > > This thread is a symptom off a specific problem: a failure to seek review for > the work before committing. Actually, I asked several people to look at ethng on the wiki. I was fairly clear that that was very close to what I wanted to commit. I also said that I wanted to commit at this time. The only person to actually take the time to give me feedback prior to commit was Mike. In the future I will request commentary in a more pubilc forum and make my timelines more specific. > I'm sure I'm not the only person who saw this > commit and went, "So where was the public request for review for a major > change to our TCP stack?" Requests for more consistent naming, etc, are > coming out now precisely because that review wasn't sort *before* committing. > TOE represents a significant architectural modification, including a new KPI > for device drivers to implement: details matter. Some of these new filenames, > function names, field names, etc, will be embedded in third-party source code > for the forseeable future. No one is saying that Kip's work isn't appreciated > or valued -- rather, that at some point with a piece of code as sensitive and > critical at TCP, it needs to go through careful review and refinement. I sent > Kip a large patch within an hour of his commit to clean up similar sorts of > problems within the file,s making it comply more with the general TCP style > but also to follow conventions for field-naming in data structures, etc, which > he committed along with refinments of his own. Sadly, often the only way to get a real discussion going is to make the immediacy of it relevant. To date I haven't made any material structural changes to TCP, I've only added the hooks that will be needed. As requested by another I will add some commentary on the purpose of each of the individual hooks to the header file. > And, FWIW, this doesn't appear to be a bikeshed, because other than you > arguing that this is turning into a bikeshed, no one seems to disagree with > the proposed renaming so far. I have no strong feelings about naming and I'm more than happy to follow whatever consensus is. My natural inclination is towards shorter names but I don't identify with my function names I just need the functionality to be present. -Kip