From owner-freebsd-hackers Wed Mar 5 4:34:55 2003 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6BADF37B48C for ; Wed, 5 Mar 2003 04:34:53 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E41843F93 for ; Wed, 5 Mar 2003 04:34:53 -0800 (PST) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id E3D7D2ED3F8; Wed, 5 Mar 2003 04:34:52 -0800 (PST) Date: Wed, 5 Mar 2003 13:34:52 +0100 From: Maxime Henrion To: "M. Warner Losh" Cc: kutulu@kutulu.org, freebsd-hackers@FreeBSD.ORG Subject: Re: D_KQFILTER & ltmdm: Patch for review? Message-ID: <20030305123452.GC63673@elvis.mu.org> References: <01be01c2e2b6$30742b00$29330f0a@lcapps.educate.com> <20030304.194917.100118237.imp@bsdimp.com> <20030304.200954.18843267.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030304.200954.18843267.imp@bsdimp.com> User-Agent: Mutt/1.4i Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG M. Warner Losh wrote: > In message: <20030304.194917.100118237.imp@bsdimp.com> > "M. Warner Losh" writes: > : : static struct cdevsw sio_cdevsw = { > : : +#if __FreeBSD_version >= 500104 /* >= 20030303 */ > : > : This syntax works even for old versions of FreeBSD. You can make it > : safe by including all the noFoo functions. phk got rid of them > : because it is safe in >= 500104 to do that. Since you want to run on > : multiple versions, it would be better/safer to do that. [...] FWIW, the correct __FreeBSD_version number for the cdevsw initialization changes is 500105. Cheers, Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message