Date: Sun, 23 Apr 2006 16:13:39 -0400 From: Kris Kennaway <kris@obsecurity.org> To: Dirk Meyer <dinoex@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/cenon Makefile Message-ID: <20060423201339.GA74819@xor.obsecurity.org> In-Reply-To: <200604231522.k3NFMROj073587@repoman.freebsd.org> References: <200604231522.k3NFMROj073587@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 23, 2006 at 03:22:27PM +0000, Dirk Meyer wrote: > dinoex 2006-04-23 15:22:27 UTC >=20 > FreeBSD ports repository >=20 > Modified files: > graphics/cenon Makefile=20 > Log: > - fix broken > only problems with gcc4.x.x > =20 > Revision Changes Path > 1.5 +4 -2 ports/graphics/cenon/Makefile > http://cvsweb.FreeBSD.org/ports/graphics/cenon/Makefile.diff?r1=3D1.4&r2= =3D1.5 > | =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > | RCS file: /usr/local/www/cvsroot/FreeBSD/ports/graphics/cenon/Makefile,v > | retrieving revision 1.4 > | retrieving revision 1.5 > | diff -u -p -r1.4 -r1.5 > | --- ports/graphics/cenon/Makefile 2006/04/22 22:10:17 1.4 > | +++ ports/graphics/cenon/Makefile 2006/04/23 15:22:27 1.5 > | @@ -2,7 +2,7 @@ > | # Date created: 16 Nov 2005 > | # Whom: Alexey Dokuchaev <danfe@FreeBSD.org> > | # > | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/graphics/cenon/Makefi= le,v 1.4 2006/04/22 22:10:17 kris Exp $ > | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/graphics/cenon/Makefi= le,v 1.5 2006/04/23 15:22:27 dinoex Exp $ > | # > | =20 > | PORTNAME=3D cenon > | @@ -17,8 +17,6 @@ EXTRACT_ONLY=3D ${DISTNAME}${EXTRACT_SUFX} > | MAINTAINER=3D danfe@FreeBSD.org > | COMMENT=3D A vector graphics tool for GNUstep > | =20 > | -BROKEN=3D Does not compile > | - > | GNUSTEP_PREFIX?=3D ${LOCALBASE}/GNUstep > | PREFIX=3D ${GNUSTEP_PREFIX} > | NO_MTREE=3D yes > | @@ -36,6 +34,10 @@ MAKEFILE=3D GNUmakefile > | OPTIONS=3D FULL_LIBRARY "Install complete Cenon Library" off > | =20 > | .include <bsd.port.pre.mk> > | + > | +.if ${CC} =3D=3D "gcc40" || ${CC} =3D=3D "gcc41" || ${CC} =3D=3D "gcc4= 2" > | +BROKEN=3D Does not compile > | +.endif It's wrong to test for CC this way - for example, what if the user has set CC=3D/usr/local/bin/gcc42? Kris --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFES9/zWry0BWjoQKURAk3cAKDrp5ELqD3PX42HNwI9SgKvbeyivACfX83H NCDHIxztHw/72/O6+rvAqW4= =1qxG -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060423201339.GA74819>