From owner-svn-src-all@freebsd.org Thu Jun 4 11:58:03 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E337337054; Thu, 4 Jun 2020 11:58:03 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49d46L5Crdz4Y8W; Thu, 4 Jun 2020 11:58:02 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id 054Bvl1O077564 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 4 Jun 2020 14:57:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 054Bvl1O077564 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id 054BvlLe077563; Thu, 4 Jun 2020 14:57:47 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 4 Jun 2020 14:57:47 +0300 From: Konstantin Belousov To: Antoine Brodin Cc: Jung-uk Kim , src-committers , svn-src-all , svn-src-head@freebsd.org Subject: Re: svn commit: r361770 - in head: include lib/libthr lib/libthr/thread share/man/man3 Message-ID: <20200604115747.GP48478@kib.kiev.ua> References: <202006032054.053KsbSs081539@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 49d46L5Crdz4Y8W X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2020 11:58:03 -0000 On Thu, Jun 04, 2020 at 07:51:42AM +0200, Antoine Brodin wrote: > On Thu, Jun 4, 2020 at 4:30 AM Jung-uk Kim wrote: > > > > It broke Firefox build and I found Linux pthread_{get,set}name_np(3) > > returns int. > > > > https://linux.die.net/man/3/pthread_getname_np > > > > I guess you need to write a wrapper. Please revert this patch for now. > > Hi, > > It broke devel/glib20 too, which now tries to use the function > without including the header: > http://beefy18.nyi.freebsd.org/data/head-amd64-default/p537862_s361780/logs/errors/glib-2.56.3_7,1.log I reworked the change, please see the updated review https://reviews.freebsd.org/D25117