From owner-svn-src-head@freebsd.org Thu Feb 23 19:01:10 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 194B8CE9663 for ; Thu, 23 Feb 2017 19:01:10 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm10-vm0.bullet.mail.ne1.yahoo.com (nm10-vm0.bullet.mail.ne1.yahoo.com [98.138.91.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D2D5416FC for ; Thu, 23 Feb 2017 19:01:09 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1487876462; bh=GOUyObMy6G8esnKUvUAg1LeIHvUnF0Sf02zPUkNhkGw=; h=From:Subject:To:References:Cc:Date:In-Reply-To:From:Subject; b=loHtJVAZYobkZwnaNHTEQHbubqqwgfmt8HfeD6CIbxbH2GdaG5PMQz/e1dfR6apvTFOjhjHgGoU0fFLzsiz3hQsgTkoypIEEkroqt7XjJYB4Kys6Cz4s/r0okEsttxU2joLH8DuyJ0Gv+syq4emRWKLimpZxp/IBkcxuwCry6JqF4RDLbloEbXTdQ2DdCbq7sf6G75TM8M56ShbY23/hOooh9/GC/d2wrCnyV0S/D0hT/DBjxBSZkgVDrQ1dtRjAmsGAnbWTsXcnAHeEeHWdiXtUZxK/sPkTiNebKIy/B3+sPW7fGJIT4CfKuvohkmlVW89MYjMcpIz17iyHMdWiSQ== Received: from [98.138.100.112] by nm10.bullet.mail.ne1.yahoo.com with NNFMP; 23 Feb 2017 19:01:02 -0000 Received: from [98.138.84.47] by tm103.bullet.mail.ne1.yahoo.com with NNFMP; 23 Feb 2017 19:01:02 -0000 Received: from [127.0.0.1] by smtp115.mail.ne1.yahoo.com with NNFMP; 23 Feb 2017 19:01:02 -0000 X-Yahoo-Newman-Id: 767703.79671.bm@smtp115.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: JCd6_Q0VM1nwAcxJ7YaQig458E58.lluZMfPpyqCN_8DeFr YHdCHvz9LDDlx_Ob.qY9.m9uYq9rhBjoZdjCFxQbrQX9ryvJQLVtt1EI2KKb dvY_t_jglHPJ3GvoXEcl6qSA3ytN85Z_QHtlvoaFVLy.6F98GlZpfi5rr.QV NOgZCWX_Oc1NbRjXQjA_YwDWT0.xdQUTJnmYyKV.XGuPifhix4iDsexP6dch Nd6gU_jidtaubqADWJ3_QwRZttObDId6xgo3JIoVJhSye4hQDFns_7uu3wC_ TTAxtiOLL1pGWpgFPAf7UHLZoJC_LbhnE1D3GxkCL_VZvPo8FzS9Dn.KScOV bTlWzT1KpwNhBdLT8JgeFeuqNQS__FX49EozuaJJ.fqjdAPCysM7e6ElJUHR xZsabvRnxa4QExMsVCnVQ_Exu1ugUeVo93zNBJaYc99Tl9qkmQW9rm8NjD._ NCW_OUVw5ou15y3ysEo6eoUj6S4inh7x5PpG0AyY8IacvbqAB_gpNFcWO9iB nTDxWq2jncEF8wwlWb.ffblYcYTfMcpvTdYK55t3dv.8Bbxw- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf From: Pedro Giffuni Subject: Re: svn commit: r314145 - in head/sys/dev/vxge: . vxgehal To: John Baldwin References: <201702231610.v1NGAGOK040762@repo.freebsd.org> <114455088.Nuga6bxpH7@ralph.baldwin.cx> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Organization: Apache Software Foundation Message-ID: <3ada5f67-4ed3-d690-5aca-7725332e2a02@apache.org> Date: Thu, 23 Feb 2017 14:03:44 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <114455088.Nuga6bxpH7@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 19:01:10 -0000 On 02/23/17 13:16, John Baldwin wrote: > On Thursday, February 23, 2017 04:10:16 PM Pedro F. Giffuni wrote: >> Author: pfg >> Date: Thu Feb 23 16:10:15 2017 >> New Revision: 314145 >> URL: https://svnweb.freebsd.org/changeset/base/314145 >> >> Log: >> dev/vxe: double assignments. >> >> Fix some suspicious code, likely caused by excessive copy-pasting. >> >> Found with: coccinelle (da.cocci) >> MFC after: 2 weeks >> >> Modified: >> head/sys/dev/vxge/vxge.c >> head/sys/dev/vxge/vxgehal/vxgehal-config.c >> >> Modified: head/sys/dev/vxge/vxge.c >> ============================================================================== >> --- head/sys/dev/vxge/vxge.c Thu Feb 23 16:07:45 2017 (r314144) >> +++ head/sys/dev/vxge/vxge.c Thu Feb 23 16:10:15 2017 (r314145) >> @@ -2312,7 +2312,7 @@ vxge_vpath_open(vxge_dev_t *vdev) >> vpath->rx_ticks = ticks; >> >> vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; >> - vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; >> + vpath->rti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL; > > Probably use VXGE_DEFAULT_TI_RTIMER_VAL instead of TI? > Good catch, fixed as r314158. Thanks! Pedro.