From owner-freebsd-arch@FreeBSD.ORG Wed Mar 8 16:24:02 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC74816A420 for ; Wed, 8 Mar 2006 16:24:02 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd3mo3so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE38143D69 for ; Wed, 8 Mar 2006 16:23:55 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd4mr4so.prod.shaw.ca (pd4mr4so-qfe3.prod.shaw.ca [10.0.141.215]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IVT00FX7HILQE60@l-daemon> for arch@freebsd.org; Wed, 08 Mar 2006 09:23:09 -0700 (MST) Received: from pn2ml10so.prod.shaw.ca ([10.0.121.80]) by pd4mr4so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IVT00AL6HILQ9D0@pd4mr4so.prod.shaw.ca> for arch@freebsd.org; Wed, 08 Mar 2006 09:23:09 -0700 (MST) Received: from [192.168.0.60] ([24.82.18.31]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IVT007VJHIK5950@l-daemon> for arch@freebsd.org; Wed, 08 Mar 2006 09:23:09 -0700 (MST) Date: Wed, 08 Mar 2006 08:22:40 -0800 From: Colin Percival In-reply-to: <20060308.090211.97454770.imp@bsdimp.com> To: "M. Warner Losh" Message-id: <440F04D0.8050605@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Enigmail-Version: 0.94.0.0 References: <20060307.233728.42821161.imp@bsdimp.com> <20060308092207.GB679@turion.vk2pj.dyndns.org> <440EF0B0.1010203@samsco.org> <20060308.090211.97454770.imp@bsdimp.com> User-Agent: Thunderbird 1.5 (X11/20060112) Cc: arch@freebsd.org Subject: Re: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_map.c vm_page.c vm_pageq.c X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2006 16:24:02 -0000 M. Warner Losh wrote: > : Peter Jeremy wrote: > : > On Tue, 2006-Mar-07 23:37:28 -0700, M. Warner Losh wrote: > : >> Log: > : >> Remove leading __ from __(inline|const|signed|volatile). They are > : >> obsolete. This should reduce diffs to NetBSD as well. > : > > : > Also, any diff reduction with NetBSD is probably outweighed by > : > the diff increase with other FreeBSD branches. > : > > : > Maybe this should be treated like whitespace cleanup - something to > : > do if you're going to be doing something non-trivial in the source > : > file. (There are probably other cleanups in the same category). > > Would merging these to RELENG_6 help any? RELENG_5 is dead after this > release anyway... FYI, cosmetic churn causes headaches for the Security Team: It means that we have to produce lots of different patches for an issue rather than just one patch. (And inevitably we don't notice that the patches won't apply correctly until we're about to send out the advisory...) Admittedly, this isn't a major concern, but it is certainly one reason to make cosmetic changes at the same time as substantive changes rather than separately. Colin Percival