From owner-svn-src-all@FreeBSD.ORG Fri Oct 29 05:04:51 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F06721065672; Fri, 29 Oct 2010 05:04:51 +0000 (UTC) (envelope-from davidxu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B9CB78FC18; Fri, 29 Oct 2010 05:04:51 +0000 (UTC) Received: from xyf.my.dom (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9T54n2P000958; Fri, 29 Oct 2010 05:04:49 GMT (envelope-from davidxu@freebsd.org) Message-ID: <4CCAC673.7070307@freebsd.org> Date: Fri, 29 Oct 2010 13:04:51 +0000 From: David Xu User-Agent: Thunderbird 2.0.0.24 (X11/20100630) MIME-Version: 1.0 To: Garrett Cooper References: <201010270232.o9R2Wsu3084553@svn.freebsd.org> <4CC803A8.3040602@freebsd.org> <20101027082122.GD1848@garage.freebsd.pl> <4CC85552.2020100@freebsd.org> <20101027133307.GQ2392@deviant.kiev.zoral.com.ua> <4CC851CC.80509@freebsd.org> <4CC9483C.7050507@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, Pawel Jakub Dawidek , svn-src-all@freebsd.org, Andriy Gapon , svn-src-head@freebsd.org, Kostik Belousov Subject: Re: svn commit: r214409 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2010 05:04:52 -0000 Garrett Cooper wrote: > On Thu, Oct 28, 2010 at 2:54 AM, David Xu wrote: >> Garrett Cooper wrote: >>> On Wed, Oct 27, 2010 at 9:22 AM, Andriy Gapon wrote: >>>> [patch attachment was lost] >>> Ugh... Mailman hates me I guess :(... >>> >>>> on 27/10/2010 19:07 Garrett Cooper said the following: >>>>> How about this patch? I implemented this as a readonly tunable and >>>> I don't think that it's correct to call it a tunable or use >>>> CTLFLAG_RDTUN. >>>> As I understand it is a read-only sysctl. >>> Converted to CTLFLAG_RD. >>> >>>>> sysconf tunable, because (AFAIK) the value that is being tested >>>>> shouldn't change during runtime after the system has been booted up, >>>>> and figuring that the value wasn't going to change it was better to >>>>> lose 4/8 bytes on the kernel stack instead of having to recompute the >>>>> value every time in a function call, with the associated lost heap / >>>>> stack memory in the process, as the assumption is that this libcall >>>>> was going to be called frequently by some programs. >> The patch looks fine to me. ;-) > > If no one opposes the change, could you please commit the patch for me David? > Thanks! > -Garrett > The SC_XXX constants are in rather odd order! > #define _SC_XOPEN_XCU_VERSION 117 /* user */ > #endif > > #if __BSD_VISIBLE > #define _SC_NPROCESSORS_CONF 57 > #define _SC_NPROCESSORS_ONLN 58 > #endif Does someone just want to save some typing for __BSD_VISIBLE ? It is wrong if it this true. Regards, David Xu