From owner-freebsd-hackers@FreeBSD.ORG Sat Jun 5 04:16:15 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 674211065670; Sat, 5 Jun 2010 04:16:15 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 13AF88FC19; Sat, 5 Jun 2010 04:16:14 +0000 (UTC) Received: by iwn5 with SMTP id 5so2183067iwn.13 for ; Fri, 04 Jun 2010 21:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:openpgp:content-type:content-transfer-encoding; bh=ILvFO3arqbsAjuHT5LZyTRVuYXC0iVjYy9w1sSAfBus=; b=jO9UCsv8B7Zrusy7QyM5KNLoGm0y1QWduRvFhwQK5PajkoAVgf0xG79v7pO41i7zEK ZiGF+pcZk1TDXG7/ndpY81XbJe4ONiddMO/dpDzROP2t20y/vhKC8+I0xOEtyLnceKiY v8dBkNP8iJ+LUbv2b/EIw9Fg/Q/cjGG/w+9wI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:openpgp:content-type :content-transfer-encoding; b=W1bI38BrU29hDCydH5YtZufNAft94Vl7Dt79v3+TCOHTt1/Rv9lRnDAmE3adzWUWN4 jLxMgiNJcJ0X/o/USd+/cWEzD3zULh7uRhE21ZV8qcjo6wnuGwCcOFbRv20TjUeE6hHU 4wIIBJEm965oUKYXlC9KxpeutKkUL6P5crKY8= Received: by 10.231.178.162 with SMTP id bm34mr14469160ibb.86.1275711374293; Fri, 04 Jun 2010 21:16:14 -0700 (PDT) Received: from centel.dataix.local (adsl-99-181-128-180.dsl.klmzmi.sbcglobal.net [99.181.128.180]) by mx.google.com with ESMTPS id b3sm8506163ibf.19.2010.06.04.21.16.12 (version=SSLv3 cipher=RC4-MD5); Fri, 04 Jun 2010 21:16:13 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4C09CF8B.5030006@dataix.net> Date: Sat, 05 Jun 2010 00:16:11 -0400 From: jhell User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.9) Gecko/20100515 Thunderbird MIME-Version: 1.0 To: Sean Bruno References: <1274739973.31299.23.camel@localhost.localdomain> <4BFBD838.40208@dataix.net> <1274798852.4715.1.camel@localhost.localdomain> <1274894969.2481.47.camel@localhost.localdomain> <4BFD9325.50905@dataix.net> In-Reply-To: <4BFD9325.50905@dataix.net> X-Enigmail-Version: 1.0.1 OpenPGP: id=89D8547E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-hackers , "sbruno@freebsd.org" Subject: Re: Exposing Zone Sleeps X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2010 04:16:15 -0000 On 05/26/2010 17:31, jhell wrote: > On 05/26/2010 13:29, Sean Bruno wrote: >> On Tue, 2010-05-25 at 07:47 -0700, Sean Bruno wrote: >>>> Hi Sean, >>>> >>>> Nice work on this. I applied this to stable/8 r208530 and I am in the >>>> process of compiling the kernel right now. Everything else has built & >>>> runs as expected "i386". Attached is the adjusted patch which was one >>>> modification to the line number for uz_sleeps in sys/vm/uma_int.h. >>>> >>>> 8 files changed, 106 insertions(+), 7 deletions(-) >>>> >>>> For those wishing to apply this patch and test for them self: >>>> >>>> cd /usr/src >>>> patch >>> cd /usr/src/include >>>> make obj && make depend && make includes && make install >>>> cd /usr/src/lib/libmemstat >>>> make obj && make depend && make includes && make install >>>> cd /usr/src/usr.bin/vmstat >>>> make obj && make depend && make install >>>> cd /usr/src >>>> make kernel KERNCONF=YOUR_KERN_CONF >>>> reboot >>>> >>>> Can't wait to see some results from this & I will report back with >>>> either negative results of the build & run or positive results from the >>>> stats collected. >>>> >>>> If there is anything needed feel free to let me know and I will do what >>>> is possible ASAP. >>>> >>>> Thanks again, >>>> >>>> - -- >>>> >>>> jhell >>> >>> Excellent. Please check the output of vmstat -z and the appropriate >>> sysctl. I changed the display a bit to keep it from wrapping on a >>> standard terminal. >>> >>> Sean >>> >>> P.S. My intention it to MFC this to all releases. >>> >> >> I do have a concern related to the removal of an #ifdef DDB in this >> patch. Any comments? >> >> Sean > > This was in your original patch sent to the list. I questioned it too > but as far as testing it goes it has caused no harm that I can see here > but I will add those back in along with the improvements from Garrett, > then regenerate the patch and send it back to the list. > > Regards, > Following up on this, it has been ~ 1 -> 2 weeks with this patch on 4 machines I have had in question and have not noticed any negative effects or gains from what this patch provides. On a stable/8 i386 system there were absolutely no SLEEP stat bumps recorded at all. On a second note one negative impact that I had observed is the negative ability to upgrade a stable/7 system to a stable/8 system with this patch applied due to mismatched symbols or other related symptoms that would suggest that the patch would also have to be applied to the older system and compiled before the upgrade. This all had more to do with 'vm_uma_zone' being undeclared. Although this is a nice feature I do not see any benefits for applying it to a stable/7 or stable/8 systems as those are already clean. But applying this to HEAD for debugging of sleep issues that may creep into the code would be useful as a type of alert until the next release at which it should be turned off and ejected from the tree unless it was separated into the src/tools/tools directory as a debugging tool. With all luck & kind regards, -- jhell