From owner-cvs-all@FreeBSD.ORG Thu Aug 10 23:51:02 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9BDF116A4DF; Thu, 10 Aug 2006 23:51:02 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 65A0F43D46; Thu, 10 Aug 2006 23:51:01 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k7ANoxhM006868; Fri, 11 Aug 2006 03:50:59 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k7ANoxFG006867; Fri, 11 Aug 2006 03:50:59 +0400 (MSD) (envelope-from yar) Date: Fri, 11 Aug 2006 03:50:59 +0400 From: Yar Tikhiy To: Roman Kurakin Message-ID: <20060810235058.GD5729@comp.chem.msu.su> References: <200608061106.k76B6ahO042778@repoman.freebsd.org> <44D5F2C1.7080606@inse.ru> <20060808124221.GO54416@comp.chem.msu.su> <20060808142616.S45647@fledge.watson.org> <44D89ED3.3000805@inse.ru> <20060808152429.W45647@fledge.watson.org> <44DA5C5A.70404@inse.ru> <20060810063312.GD93633@comp.chem.msu.su> <44DB13F7.3050306@inse.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44DB13F7.3050306@inse.ru> User-Agent: Mutt/1.5.9i Cc: Roman Kurakin , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Ruslan Ermilov , Robert Watson Subject: Re: cvs commit: src/share/examples/drivers make_device_driver.sh X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2006 23:51:02 -0000 On Thu, Aug 10, 2006 at 03:09:43PM +0400, Roman Kurakin wrote: > Yar Tikhiy wrote: > >On Thu, Aug 10, 2006 at 02:06:18AM +0400, Roman Kurakin wrote: > > > >>Robert Watson: > >> > >> > >>>On Tue, 8 Aug 2006, Roman Kurakin wrote: > >>> > >>> > >>>>We could add a "foo" driver to the LINT generated by this script with > >>>>notification that it was generated and all changes should be placed > >>>>to script. > >>>> > >>>I guess I can't help but wonder if a script is necessarily better than > >>>a well-commented template. > >>> > >>Today I've talked with ru@. He suggests to put an example to tree and > >>change script to produce > >>a copy of driver using example from tree as a template via sed or smth > >>like that. It sounds like > >>a good idea. We could have a single dir in subtree with various examples > >>and a set of scripts that > >>could produce from one of the examples a driver to start with. > >> > > > >...and if you manage to make the driver do some real job so that > >people start using it in production, it will have nearly zero chance > >to fall into oblivion; it will remain in a very good shape instead. > >No, I'm telling nonsense here: A useful driver will be hacked > >sooner or later into a huge, ugly, incomprehensible beast reeking > >with features. :-) > > > If you want to add a new functionality you just need to create a new > example. > Probably it wouldn't be bad to have a driver with higher level of complexity > that can do the same (and more) than the other one that is much more simple. Of course, it's a very good idea, as long as the complex driver source stays comprehensible to readers. Usually that means adding a lot of clear comments to every new feature and around it. OTOH, it shouldn't be a halting task because a sort of a good comment is a must in the commit message anyway. -- Yar