From owner-cvs-all Sat Mar 9 11:22:21 2002 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 290D037B404; Sat, 9 Mar 2002 11:22:12 -0800 (PST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.2/8.12.2) with ESMTP id g29JLqBo002891; Sat, 9 Mar 2002 20:21:53 +0100 (CET) (envelope-from phk@critter.freebsd.dk) Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Junior Kernel Hacker task: retire DIOCGPART ioctl. In-Reply-To: Your message of "Sat, 09 Mar 2002 11:15:38 PST." <200203091915.g29JFch32767@freefall.freebsd.org> Date: Sat, 09 Mar 2002 20:21:52 +0100 Message-ID: <2890.1015701712@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Here is a nice little beginner task: The DIOCGPART ioctl is a misfeature which should be discontinued. To do so, two new ioctls must be constructed: DIOCGSECSIZE returning the sectorsize. DIOCGTYPE returning any type from the label. The latter of these two should be general and independent of labeling format, so an ascii-string return is preferable. I would suggest a qualified format like "MBR:165" "BSD:Vinum" "BSD:4.2BSD" Send me email if you're interested... Poul-Henning In message <200203091915.g29JFch32767@freefall.freebsd.org>, Poul-Henning Kamp writes: >phk 2002/03/09 11:15:38 PST > > Modified files: > sys/sys disklabel.h > Log: > Hide the DIOCGPART ioctl from userland where it has no decent use. > > It's use in the kernel is also highly suspect due to the total absense > of any kind of lifetime definition of the passed pointers. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message